Skip to content

Feature/ssl certbot for new URL #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haphantran merged 2 commits into from
Apr 12, 2026
Merged

Feature/ssl certbot for new URL #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb9cb9
feat: add SSL via Let's Encrypt/Certbot and migrate to micss-lab.be
haphantran Apr 12, 2026
ec4a7fd
update URL
haphantran Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/health-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
while [ $attempt -le $max_attempts ]; do
echo "Attempt $attempt of $max_attempts..."

if response=$(curl -sf --max-time 30 https://spatialdsl.tmusml.cloud/api/health); then
if response=$(curl -sf --max-time 30 ${{ vars.APP_URL }}/api/health); then
echo "$response"
Comment on lines 21 to 23
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow now depends on the repository/org Actions variable APP_URL (vars.APP_URL). If it isn’t defined, this expression resolves to an empty string and curl will run against /api/health, causing the job to fail with an invalid/missing URL. Consider providing a safe default in the expression (or setting an env: APP_URL: ${{ vars.APP_URL || 'https://micss-lab.be' }} and using $APP_URL), and quote the URL to avoid shell word-splitting.

Copilot uses AI. Check for mistakes.
if echo "$response" | jq -e '.success == true' > /dev/null; then
echo "✅ Health check passed"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
## Overview
A full-stack model-driven engineering platform for designing domain-specific languages and working with models end-to-end.

**Live demo:** [https://spatialdsl.tmusml.cloud](https://spatialdsl.tmusml.cloud)
**Live demo:** [https://micss-lab.be](https://micss-lab.be)

You can:

Expand Down
4 changes: 2 additions & 2 deletions docker-compose.prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ services:
DATABASE_URL: postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@db:5432/${POSTGRES_DB}?schema=public
PORT: 3001
NODE_ENV: production
CORS_ORIGIN: https://spatialdsl.tmusml.cloud
CORS_ORIGIN: https://micss-lab.be
MAX_FILE_SIZE: 52428800
Comment on lines 28 to 32
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description mention "ssl certbot", but the changes in this PR only update the public URL references (README, compose env vars, health check). Either update the PR title/description to match the actual scope, or include the missing certbot-related configuration changes if they were intended.

Copilot uses AI. Check for mistakes.
LOG_LEVEL: info
JWT_SECRET: ${JWT_SECRET}
Expand All @@ -37,7 +37,7 @@ services:
ADMIN_PASSWORD: ${ADMIN_PASSWORD:-}
RESEND_API_KEY: ${RESEND_API_KEY:-}
RESEND_FROM_EMAIL: ${RESEND_FROM_EMAIL:-noreply@example.com}
APP_URL: ${APP_URL:-https://spatialdsl.tmusml.cloud}
APP_URL: ${APP_URL:-https://micss-lab.be}
# No ports exposed to host — frontend nginx proxies /api/* internally

frontend:
Expand Down