Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes WireGuard connection creation so NetworkManager receives a native wireguard profile without the invalid wireguard.service-type property, matching the behavior described in issue #420.
Changes:
- Removed insertion of
service-typeinto the WireGuard settings section. - Updated the WireGuard builder test to assert that
service-typeis absent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nmrs/src/api/builders/wireguard_builder.rs |
Stops adding the invalid service-type property to native WireGuard settings. |
nmrs/src/api/builders/vpn.rs |
Updates the related unit test expectation for WireGuard settings. |
WireGuardBuilder::build() inserted a service-type property into the wireguard settings section. WireGuard in NetworkManager is a native kernel connection type (connection.type = "wireguard"), not a plugin VPN. The wireguard section does not have a service-type property — only the vpn section for plugin VPNs (like OpenVPN) does. This caused NM to reject the profile with wireguard.service-type: unknown property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WireGuardBuilder::build()inserted a service-type property into thewireguardsettings section. WireGuard in NetworkManager is a native kernel connection type (connection.type = "wireguard"), not a plugin VPN. The wireguard section does not have a service-type property — only the vpn section for plugin VPNs (like OpenVPN) does. This caused NM to reject the profile with wireguard.service-type: unknown property.Fixes #420