Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions nmrs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
All notable changes to the `nmrs` crate will be documented in this file.

## [Unreleased]
### Fixed
- WireGuard builder now sets `service-type` property correctly ([#421](https://github.com/networkmanager-rs/nmrs/pull/421))

## [3.1.3] - 2026-05-14
### Fixed
Expand All @@ -11,7 +13,7 @@ All notable changes to the `nmrs` crate will be documented in this file.
(No changes documented)

## [3.1.2] - 2026-05-14
- `set_bluetooth_radio_enabled` now toggles kernel rfkill before BlueZ adapter `Powered`, fixing airplane-mode state desync with rfkill-based consumers ([#417](https://github.com/cachebag/nmrs/issues/418))
- `set_bluetooth_radio_enabled` now toggles kernel rfkill before BlueZ adapter `Powered`, fixing airplane-mode state desync with rfkill-based consumers ([#417](https://github.com/networkmanager-rs/nmrs/issues/418))

## [3.1.1] - 2026-05-13
### Fixed
Expand All @@ -21,17 +23,17 @@ All notable changes to the `nmrs` crate will be documented in this file.
those radios were disabled, preventing UI/state divergence where airplane
mode appears to fail while radios remain disabled. On hosts with no
Wi-Fi/WWAN device detected, `set_airplane_mode` can still return
`BluetoothToggleFailed`. ([#417](https://github.com/cachebag/nmrs/issues/417))
`BluetoothToggleFailed`. ([#417](https://github.com/networkmanager-rs/nmrs/issues/417))

## [3.1.0] - 2026-05-08
- Implement loopback support ([#391](https://github.com/cachebag/nmrs/issues/391))
- Implement add VLAN (802.1Q) device support with VlanConfig model and connection builder([#392](https://github.com/cachebag/nmrs/issues/392))
- Implement loopback support ([#391](https://github.com/networkmanager-rs/nmrs/issues/391))
- Implement add VLAN (802.1Q) device support with VlanConfig model and connection builder([#392](https://github.com/networkmanager-rs/nmrs/issues/392))

### Added
- `RadioState::present` indicates whether a controllable instance of the radio
exists on the host. `RadioState::with_presence(enabled, hardware_enabled,
present)` constructor; `RadioState::new` keeps existing behavior and defaults
`present = true`. ([#396](https://github.com/cachebag/nmrs/issues/396))
`present = true`. ([#396](https://github.com/networkmanager-rs/nmrs/issues/396))

### Fixed
- `NetworkManager::wifi_state` and `wwan_state` now set `RadioState::present`
Expand Down
11 changes: 5 additions & 6 deletions nmrs/src/api/builders/vpn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -440,17 +440,16 @@ mod tests {
}

#[test]
fn vpn_section_has_wireguard_service_type() {
fn wireguard_section_has_no_service_type() {
let creds = create_test_credentials();
let opts = create_test_options();

let settings = build_wireguard_connection(&creds, &opts).unwrap();
let vpn = settings.get("wireguard").unwrap();
let wg = settings.get("wireguard").unwrap();

let service_type = vpn.get("service-type").unwrap();
assert_eq!(
service_type,
&Value::from("org.freedesktop.NetworkManager.wireguard")
assert!(
wg.get("service-type").is_none(),
"kernel WireGuard connections must not have a service-type property"
);
}

Expand Down
4 changes: 0 additions & 4 deletions nmrs/src/api/builders/wireguard_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,6 @@ impl WireGuardBuilder {

// Build wireguard section
let mut wireguard = HashMap::new();
wireguard.insert(
"service-type",
Value::from("org.freedesktop.NetworkManager.wireguard"),
);
wireguard.insert("private-key", Value::from(private_key));

// Build peers array
Expand Down