fix: OIDC issuerCA to load all certificates from PEM bundle#874
Open
JoaoBraveCoding wants to merge 2 commits intoobservatorium:mainfrom
Open
fix: OIDC issuerCA to load all certificates from PEM bundle#874JoaoBraveCoding wants to merge 2 commits intoobservatorium:mainfrom
JoaoBraveCoding wants to merge 2 commits intoobservatorium:mainfrom
Conversation
philipgough
previously approved these changes
Feb 26, 2026
Contributor
philipgough
left a comment
philipgough
left a comment
There was a problem hiding this comment.
/lgtm
@squat any concerns?
Contributor
Author
|
Is there anything else I can help with to get this one merged? |
squat
reviewed
Mar 30, 2026
Member
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
I'm find with this functionality. I just have one style comment to improve clarity and prevent future mistakes with validation.
Contributor
Author
|
@squat thanks for the reply! However, I don't think your comment went through |
squat
reviewed
Mar 30, 2026
authentication/oidc.go
Outdated
| for { | ||
| block, rest = pem.Decode(rest) | ||
| if block == nil { | ||
| if len(config.issuerCAs) == 0 { |
Member
There was a problem hiding this comment.
For style and clarity, let's instead break on line 107, ie, whenever block == nil since that's the exit condition and let's move this check outside the block, since that's the validation. I think that would be clearer IMO.
Member
|
@JoaoBraveCoding oops. I just reposted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves https://issues.redhat.com/browse/LOG-8727