Skip to content

feat: add CoursewareViewRedirectURL pipeline steps#2548

Open
pwnage101 wants to merge 1 commit into
masterfrom
pwnage101/ENT-11544
Open

feat: add CoursewareViewRedirectURL pipeline steps#2548
pwnage101 wants to merge 1 commit into
masterfrom
pwnage101/ENT-11544

Conversation

@pwnage101
Copy link
Copy Markdown
Contributor

@pwnage101 pwnage101 commented Mar 5, 2026

This commit replaces most enterprise-specific logic serving the purpose
of conditionally blocking courseware access.

Enterprise steps added:

  • EnterpriseStartDateAccessFailureStep supplies an enterprise-specific start-date error for enterprise learners.
  • ActiveEnterpriseCheckStep denies access when the learner's active EnterpriseCustomer differs from the enrollment's customer.

Consent steps added:

  • DataSharingConsentRedirectStep supplies a redirect URL to collect data sharing consent when it is required.
  • DataSharingConsentCourseAccessStep denies access when consent is required.

ENT-11544


Blocked by:

Blocks:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.00%. Comparing base (306ca8a) to head (b4c83bf).

Files with missing lines Patch % Lines
consent/helpers.py 50.00% 11 Missing ⚠️

❌ Your patch check has failed because the patch coverage (62.06%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
- Coverage   86.04%   86.00%   -0.04%     
==========================================
  Files         250      251       +1     
  Lines       16700    16740      +40     
  Branches     1657     1662       +5     
==========================================
+ Hits        14369    14397      +28     
- Misses       1997     2008      +11     
- Partials      334      335       +1     
Flag Coverage Δ
unittests 86.00% <62.06%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pwnage101 pwnage101 force-pushed the pwnage101/ENT-11544 branch 4 times, most recently from b279908 to fcd378f Compare May 20, 2026 16:37
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-11544 branch from fcd378f to e6bff04 Compare May 21, 2026 16:45
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-11544 branch 6 times, most recently from a0204dc to e885e65 Compare June 2, 2026 22:48
@pwnage101 pwnage101 marked this pull request as ready for review June 2, 2026 23:39
Comment thread enterprise/settings/common.py Outdated
Comment thread enterprise/filters/courseware.py Outdated
Comment thread tests/filters/test_courseware.py Outdated
Comment thread consent/helpers.py
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-11544 branch 9 times, most recently from 2072bed to 65a6b29 Compare June 4, 2026 03:19
This commit replaces most enterprise-specific logic serving the purpose
of conditionally blocking courseware access.

Enterprise steps added:
- EnterpriseStartDateAccessFailureStep supplies an enterprise-specific start-date error for enterprise learners.
- ActiveEnterpriseCheckStep denies access when the learner's active EnterpriseCustomer differs from the enrollment's customer.

Consent steps added:
- DataSharingConsentRedirectStep supplies a redirect URL to collect data sharing consent when it is required.
- DataSharingConsentCourseAccessStep denies access when consent is required.

ENT-11544
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-11544 branch from 65a6b29 to 14d9cb8 Compare June 4, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants