feat: add CoursewareViewStarted, CourseStartDateValidationFailed, and CoursewareAccessChecksRequested filters#336
Open
pwnage101 wants to merge 1 commit into
Open
Conversation
pwnage101
commented
Mar 5, 2026
pwnage101
force-pushed
the
pwnage101/ENT-11544
branch
3 times, most recently
from
7e9d307 to
75be6aa
Compare
pwnage101
force-pushed
the
pwnage101/ENT-11544
branch
from
75be6aa to
39c6daf
Compare
pwnage101
force-pushed
the
pwnage101/ENT-11544
branch
8 times, most recently
from
f11df07 to
b80e6ce
Compare
pwnage101
changed the title
kiram15
reviewed
Jun 3, 2026
| def __init__(self, url: str) -> None: | ||
| """Store the redirect URL on the exception instance.""" | ||
| super().__init__() | ||
| self.url = url |
Contributor
There was a problem hiding this comment.
This differs from other exceptions in the codebase that typically pass a message, can we mimic this behavior?
https://github.com/pwnage101/openedx-filters/blob/b80e6cedade87031fcd9553d1fd102cceea3564d/openedx_filters/learning/filters.py#L60
| * Added GradeEventContextRequested filter | ||
|
|
||
| [3.1.0] - 2025-04-06 | ||
| [3.1.0] - 2026-04-06 |
|
|
||
| Trigger: | ||
| - Repository: openedx/edx-platform | ||
| - Path: lms/djangoapps/courseware/access_utils.py |
Contributor
There was a problem hiding this comment.
Path is incorrect, should be enterprise/filters/courseware.py
Contributor
Author
There was a problem hiding this comment.
The path you shared is an edx-enterprise path to the pipeline step, but what's actually needed is the "Trigger" a.k.a. the call site of the filter.
pwnage101
force-pushed
the
pwnage101/ENT-11544
branch
3 times, most recently
from
8b05d30 to
3c66960
Compare
… CoursewareAccessChecksRequested filters Plugins can now supply a courseware view redirect URL, inject specific error payloads when course start-date validation fails, or deny courseware access with a priority (non-bypassable) error. ENT-11544
pwnage101
force-pushed
the
pwnage101/ENT-11544
branch
from
3c66960 to
ca033ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins can now supply a courseware view redirect URL, inject specific error
payloads when course start-date validation fails, or deny courseware access
with a priority (non-bypassable) error.
ENT-11544
Blocks: