MGMT-24835: configuring the auto mode for assisted-service#82028
Draft
andrej1991 wants to merge 1 commit into
Draft
MGMT-24835: configuring the auto mode for assisted-service#82028andrej1991 wants to merge 1 commit into
andrej1991 wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@andrej1991: This pull request references MGMT-24835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
WalkthroughThe pull request updates assisted-service CI YAML definitions to use pipeline-level change filters, explicitly disable unconditional execution for affected jobs, mark selected jobs optional, and register assisted-service for automatic pipeline triggering. ChangesAssisted-service CI gating
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrej1991 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andrej1991
force-pushed
the
lgtm-mode-assisted-service
branch
from
July 16, 2026 17:38
736c509 to
ea8b9a0
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml`:
- Around line 41-45: The assisted-service CI configuration changes require
regenerated artifacts. Run make update, then commit the resulting
ci-operator/jobs/... and zz_generated_metadata outputs for all affected sites:
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml
(41-45), release-4.21.yaml (41-45), release-4.22.yaml (41-45), release-4.23.yaml
(41-45), release-5.0.yaml (97-106), release-5.1.yaml (179-181),
master__edge.yaml (167-173), release-ocm-2.11.yaml (97-106), and v2.54.yaml
(97-106).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7112eff2-64d8-4dc0-97ef-a898c1ac3b0a
⛔ Files ignored due to path filters (35)
ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-assisted-version-placeholder-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.42-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.43-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.45-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.46-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.47-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.48-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.49-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.50-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.51-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.52-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.53-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.54-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (37)
ci-operator/config/openshift/assisted-service/openshift-assisted-service-assisted-version-placeholder.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-master.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.12.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.13.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.14.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.15.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.16.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.17.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.18.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.19.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.21.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.22.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.23.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.0.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.1.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.12.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.13.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.14.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.16.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.17.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.42.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.43.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.45.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.47.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.49.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.50.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.51.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.52.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.54.yamlcore-services/pipeline-controller/config.yaml
Comment on lines
+41
to
+45
| - always_run: false | ||
| as: e2e-agent-compact-ipv4 | ||
| capabilities: | ||
| - intranet | ||
| skip_if_only_changed: ^openshift/|^\.tekton/|^docs/|\.md$|^(LICENSE|OWNERS|OWNERS_ALIASES)$ | ||
| pipeline_skip_if_only_changed: ^openshift/|^\.tekton/|^docs/|\.md$|^(LICENSE|OWNERS|OWNERS_ALIASES)$ |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the relevant files and any nearby generated artifacts in the assisted-service area.
git ls-files ci-operator/config/openshift/assisted-service | sed -n '1,120p'
printf '\n--- generated / jobs / metadata matches ---\n'
git ls-files | rg '^ci-operator/(jobs|config)/.*assisted-service|zz_generated_metadata|generated' || true
printf '\n--- make targets mentioning update ---\n'
rg -n 'make update|zz_generated_metadata|ci-operator/jobs|generated jobs' -S Makefile ci-operator .github . 2>/dev/null || trueRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the assisted-service CI config file patterns and whether they are generated source-of-truth entries.
for f in \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.21.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.22.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.23.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.0.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.1.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.54.yaml
do
echo "== $f =="
sed -n '1,220p' "$f" | rg -n 'always_run:|optional:|pipeline_skip_if_only_changed:|skip_if_only_changed:|pipeline_run_if_changed:' -n -C 1 || true
echo
done
printf '\n--- look for regenerated outputs tied to assisted-service ---\n'
git ls-files | rg '^(ci-operator/jobs|ci-operator/config)/.*assisted-service|zz_generated_metadata' || trueRepository: openshift/release
Length of output: 31152
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Check whether the repo contains a make target or script specifically for ci-operator config regeneration.
rg -n '(^|[[:space:]])update(:|[[:space:]])|make update|update generated|ci-operator config' -S Makefile . 2>/dev/null | sed -n '1,120p'Repository: openshift/release
Length of output: 16103
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Read the affected config snippets and check for sibling generated artifact directories.
for f in \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.21.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.22.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.23.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.0.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.1.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.54.yaml
do
echo "===== $f ====="
sed -n '1,260p' "$f" | rg -n 'always_run:|optional:|skip_if_only_changed:|pipeline_skip_if_only_changed:|pipeline_run_if_changed:' -C 1 || true
done
printf '\n===== assisted-service generated file candidates =====\n'
git ls-files | rg '^ci-operator/(jobs|config)/.*assisted-service|zz_generated_metadata|generated' || true
printf '\n===== make/update references =====\n'
rg -n 'make update|zz_generated_metadata|generated Prow|generated jobs|ci-operator/config' -S Makefile hack ci-operator 2>/dev/null | sed -n '1,160p' || trueRepository: openshift/release
Length of output: 50373
Regenerate the assisted-service CI artifacts
These ci-operator/config/openshift/assisted-service/* changes alter generated Prow job definitions; run make update and commit the updated ci-operator/jobs/... and zz_generated_metadata outputs.
📍 Affects 9 files
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml#L41-L45(this comment)ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.21.yaml#L41-L45ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.22.yaml#L41-L45ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.23.yaml#L41-L45ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.0.yaml#L97-L106ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.1.yaml#L179-L181ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml#L167-L173ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11.yaml#L97-L106ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.54.yaml#L97-L106
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml`
around lines 41 - 45, The assisted-service CI configuration changes require
regenerated artifacts. Run make update, then commit the resulting
ci-operator/jobs/... and zz_generated_metadata outputs for all affected sites:
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml
(41-45), release-4.21.yaml (41-45), release-4.22.yaml (41-45), release-4.23.yaml
(41-45), release-5.0.yaml (97-106), release-5.1.yaml (179-181),
master__edge.yaml (167-173), release-ocm-2.11.yaml (97-106), and v2.54.yaml
(97-106).
Sources: Coding guidelines, Learnings
First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
andrej1991
force-pushed
the
lgtm-mode-assisted-service
branch
from
July 16, 2026 21:35
ea8b9a0 to
27ffc73
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml`:
- Line 152: Keep the e2e-metal-assisted presubmit on an automatic trigger by
removing the always_run: false setting in
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml:152,
openshift-assisted-service-v2.48.yaml:156,
openshift-assisted-service-v2.51.yaml:156, and
openshift-assisted-service-v2.52.yaml:156; do not rely on optional: true to
trigger it.
- Around line 267-271: Update the pipeline_run_if_changed filter for
e2e-metal-assisted-virtualization-4-18 to match the entire CNV subtree by
changing the CNV pattern from the literal path to the path followed by .*. Apply
this change in
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml
lines 267-271 and
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml
lines 267-271.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 26a98ec7-65d3-4934-a542-96580696535e
⛔ Files ignored due to path filters (34)
ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-assisted-version-placeholder-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.12-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.13-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.42-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.43-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.45-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.46-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.47-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.48-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.49-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.50-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.51-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.52-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.53-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.54-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (36)
ci-operator/config/openshift/assisted-service/openshift-assisted-service-assisted-version-placeholder.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-master.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.13.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.14.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.15.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.16.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.17.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.18.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.19.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.21.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.22.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.23.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.0.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.1.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.12.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.13.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.14.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.16.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.17.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.42.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.43.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.45.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.47.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.49.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.50.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.51.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.52.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.54.yamlcore-services/pipeline-controller/config.yaml
🚧 Files skipped from review as they are similar to previous changes (29)
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.14.yaml
- core-services/pipeline-controller/config.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.0.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-master.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.17.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.13.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.20.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.12.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.23.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.18.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.16.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-5.1.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.11.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.15.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.17.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.50.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.54.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.47.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.19.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-assisted-version-placeholder.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.45.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.43.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-4.21.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.13.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.42.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.53.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml
- ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.49.yaml
| OPENSHIFT_VERSION=4.20 | ||
| workflow: assisted-ofcir-baremetal | ||
| - always_run: true | ||
| - always_run: false |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
files=(
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.51.yaml
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.52.yaml
)
for f in "${files[@]}"; do
echo "===== $f ====="
# show the job stanza around the lines mentioned in the review
nl -ba "$f" | sed -n '130,180p'
echo
done
echo "===== Search for pipeline_run_if_changed / always_run in these files ====="
rg -n "always_run:|optional: true|pipeline_run_if_changed|run_if_changed" "${files[@]}"
echo "===== Search for the job name in these files ====="
rg -n "e2e-metal-assisted" "${files[@]}"Repository: openshift/release
Length of output: 292
🏁 Script executed:
#!/bin/bash
set -euo pipefail
files=(
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.51.yaml
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.52.yaml
)
for f in "${files[@]}"; do
echo "===== $f (lines 130-180) ====="
awk 'NR>=130 && NR<=180 { printf "%5d %s\n", NR, $0 }' "$f"
echo
done
echo "===== trigger-field search ====="
rg -n "always_run:|optional: true|pipeline_run_if_changed|run_if_changed|e2e-metal-assisted" "${files[@]}"Repository: openshift/release
Length of output: 33042
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Look for docs or schema references that describe always_run / run_if_changed behavior.
rg -n "always_run|run_if_changed|pipeline_run_if_changed|optional: true" \
docs ci-operator test images hack .github 2>/dev/null | sed -n '1,200p'
echo "===== schema / generated config hints ====="
fd -a ".*(schema|config|ci-operator).*" ci-operator docs test 2>/dev/null | sed -n '1,120p'Repository: openshift/release
Length of output: 29247
Keep e2e-metal-assisted on an automatic trigger. always_run: false makes this presubmit manual-only here unless a pipeline_run_if_changed filter is added; optional: true does not trigger it.
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml#L152-L156ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml#L152-L156ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.51.yaml#L156-L160ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.52.yaml#L156-L160
📍 Affects 4 files
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml#L152-L152(this comment)ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml#L156-L156ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.51.yaml#L156-L156ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.52.yaml#L156-L156
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml`
at line 152, Keep the e2e-metal-assisted presubmit on an automatic trigger by
removing the always_run: false setting in
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml:152,
openshift-assisted-service-v2.48.yaml:156,
openshift-assisted-service-v2.51.yaml:156, and
openshift-assisted-service-v2.52.yaml:156; do not rely on optional: true to
trigger it.
Comment on lines
+267
to
+271
| - always_run: false | ||
| as: e2e-metal-assisted-virtualization-4-18 | ||
| capabilities: | ||
| - intranet | ||
| run_if_changed: ^(internal/operators/nodehealthcheck/.*|internal/operators/selfnoderemediation/.*|internal/operators/fenceagentsremediation/.*|internal/operators/nodemaintenance/.*|internal/operators/kubedescheduler/.*|internal/operators/cnv|internal/operators/mtv/.*|internal/operators/nmstate/.*)$ | ||
| pipeline_run_if_changed: ^(internal/operators/nodehealthcheck/.*|internal/operators/selfnoderemediation/.*|internal/operators/fenceagentsremediation/.*|internal/operators/nodemaintenance/.*|internal/operators/kubedescheduler/.*|internal/operators/cnv|internal/operators/mtv/.*|internal/operators/nmstate/.*)$ |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
set -euo pipefail
# Inspect the relevant YAML fragments
for f in ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml; do
echo "===== $f ====="
sed -n '260,276p' "$f"
done
echo "===== paths under internal/operators/cnv ====="
git ls-files 'internal/operators/cnv/**' | sed -n '1,120p'
echo "===== regex behavior probe ====="
python3 - <<'PY'
import re
pat = re.compile(r'^(internal/operators/nodehealthcheck/.*|internal/operators/selfnoderemediation/.*|internal/operators/fenceagentsremediation/.*|internal/operators/nodemaintenance/.*|internal/operators/kubedescheduler/.*|internal/operators/cnv|internal/operators/mtv/.*|internal/operators/nmstate/.*)$')
tests = [
"internal/operators/cnv",
"internal/operators/cnv/",
"internal/operators/cnv/foo",
"internal/operators/cnv/foo/bar.go",
"internal/operators/cnv.go",
]
for s in tests:
print(f"{s!r}: {bool(pat.match(s))}")
PYRepository: openshift/release
Length of output: 2243
🏁 Script executed:
set -euo pipefail
echo "===== paths starting with internal/operators/cnv ====="
git ls-files 'internal/operators/cnv*' | sed -n '1,120p'
echo "===== any cnv mentions in repository paths ====="
git ls-files | rg '^internal/operators/.*/?cnv'Repository: openshift/release
Length of output: 259
🌐 Web query:
"site:github.com openshift/assisted-service \"internal/operators/cnv\""
💡 Result:
The directory internal/operators/cnv in the openshift/assisted-service GitHub repository contains the implementation of the Container Native Virtualization (CNV) operator plugin for the Assisted Service [1][2]. Key technical aspects of this directory include: - Purpose: This package manages the lifecycle and integration of the OpenShift Virtualization (CNV) operator within the Assisted Service [1]. - Key Files: - cnv_operator.go: Defines the core logic for the CNV operator plugin, including its MonitoredOperator structure, subscription details (e.g., namespace openshift-cnv, subscription name hco-operatorhub), and methods for calculating preflight hardware requirements (such as CPU, RAM, and disk needs for virtualization) [1][3]. - manifest.go: Contains the Kubernetes manifest templates, including the Subscription object used to install the operator via OLM (Operator Lifecycle Manager) [3]. - Recent Evolution: The implementation has evolved significantly over time. Recent changes include simplifying the dependency and preflight requirement APIs [4] and removing previously hardcoded dependencies on other operators like LSO (Local Storage Operator) or LVMS [4][5]. Developers extending or working with this service typically use this directory to define how CNV is validated and deployed during cluster installation [2].
Citations:
- 1: https://github.com/openshift/assisted-service/blob/master/internal/operators/cnv/cnv_operator.go
- 2: openshift/assisted-service@15f5bc0
- 3: openshift/assisted-service@da68432
- 4: MGMT-24682: Remove LSO and LVMS as CNV operator dependencies assisted-service#10541
- 5: MGMT-19054: remove LSO as default for CNV on ARM assisted-service#6879
🌐 Web query:
site:github.com/openshift/assisted-service "internal/operators/cnv/"
💡 Result:
The directory internal/operators/cnv/ is a component of the OpenShift assisted-service repository on GitHub [1][2]. This service is designed to automate the installation of OpenShift clusters, providing pre-flight validations and configuration management for various operators [2]. Within the assisted-service architecture, the internal/operators/cnv/ package contains the plugin implementation for the OpenShift Virtualization (CNV) operator [1][3]. Its primary functions include: - Operator Configuration and Monitoring: It defines the CNV operator's integration with the assisted-service by specifying metadata such as the operator name (cnv), namespace (openshift-cnv), subscription details (hco-operatorhub), and installation timeouts [1][4]. - Pre-flight Validations: It performs hardware and cluster-level validations to ensure that the environment is suitable for deploying CNV [1][5]. For example, it checks that the host CPU has the necessary virtualization flags (e.g., vmx or svm) [1][5]. - Hardware Requirement Calculations: It computes the hardware requirements (such as CPU and memory overheads) for hosting the operator and its components [1][6]. This includes logic to account for additional resource requirements based on hardware features like GPUs and SR-IOV NICs [1][6]. - Manifest Generation: It generates the Kubernetes manifests required for bootstrapping and installing the operator during the cluster deployment process [7][8]. This package adheres to a common internal Operator interface used by the assisted-service to manage multiple OLM (Operator Lifecycle Manager) operators in a consistent manner [3].
Citations:
- 1: https://github.com/openshift/assisted-service/blob/master/internal/operators/cnv/cnv_operator.go
- 2: https://github.com/openshift/assisted-service
- 3: openshift/assisted-service@15f5bc0
- 4: openshift/assisted-service@da68432
- 5: openshift/assisted-service@bf120e7
- 6: openshift/assisted-service@7e03c41
- 7: openshift/assisted-service@8d29b4e
- 8: openshift/assisted-service@c1fcc80
🌐 Web query:
"openshift assisted-service internal/operators cnv OLM_OPERATORS"
💡 Result:
In the context of the OpenShift Assisted Service, OLM_OPERATORS (often referred to via the olm_operators parameter in the API) is an array used to specify which Operators should be installed and managed by the Assisted Installer [1][2]. The cnv (Container Native Virtualization, or OpenShift Virtualization) operator is one of the supported operators that can be included in this list [3][2]. Within the Assisted Service source code, the handling of the CNV operator is defined in internal/operators/cnv/cnv_operator.go [3]. Key points regarding this integration include: 1. API Usage: When registering or updating a cluster via the Assisted Installer API, you include the operator in the olm_operators array, for example: "olm_operators": [{"name": "cnv"}] [2]. 2. Internal Implementation: The Assisted Service uses a plugin-based architecture for OLM operators [4]. The cnv_operator.go file defines a MonitoredOperator structure that specifies details such as the operator name, the namespace (typically openshift-cnv), the subscription name (hco-operatorhub), and the operator type (models.OperatorTypeOlm) [3][5]. 3. Dependency Management: The Assisted Service manager handles these operators, automatically managing dependencies [2]. Historically, the CNV operator had dependencies on other operators like LSO (Logical Storage Operator), although dependency requirements have evolved in recent versions of the service [6][7]. 4. Monitoring: Once included, the Assisted Service monitors the status of these operators, and the information is exposed through the /v2/clusters/{cluster_id}/monitored-operators API endpoint [8]. For further implementation details or to add a new OLM operator, developers typically follow the patterns established in the internal/operators directory, which involves implementing the Operator interface and registering the operator in the OperatorManager [4][7].
Citations:
- 1: https://docs.redhat.com/en/documentation/assisted_installer_for_openshift_container_platform/2024/pdf/installing_openshift_container_platform_with_the_assisted_installer/Assisted_Installer_for_OpenShift_Container_Platform-2024-Installing_OpenShift_Container_Platform_with_the_Assisted_Installer-en-US.pdf
- 2: https://docs.redhat.com/en/documentation/openshift_container_platform/4.12/html/assisted_installer_for_openshift_container_platform/assembly_installing-operators
- 3: https://github.com/openshift/assisted-service/blob/master/internal/operators/cnv/cnv_operator.go
- 4: openshift/assisted-service@15f5bc0
- 5: openshift/assisted-service@da68432
- 6: MGMT-24682: Remove LSO and LVMS as CNV operator dependencies assisted-service#10541
- 7: openshift/assisted-service@23cc1d5
- 8: https://api.openshift.com/api/assisted-install/v2/openapi
🌐 Web query:
"site:github.com \"internal/operators/nodehealthcheck\" \"internal/operators/cnv\""
💡 Result:
The paths internal/operators/nodehealthcheck and internal/operators/cnv refer to Go packages within the openshift/assisted-service repository on GitHub [1][2][3]. This repository contains the logic for the Assisted Service, which facilitates the deployment and installation of OpenShift clusters [1]. The internal/operators/cnv directory contains the implementation for the Container Native Virtualization (CNV) operator plugin [1], which manages the installation and configuration of CNV on OpenShift clusters, including handling preflight requirements and operator subscription data [1][4]. The internal/operators/nodehealthcheck directory contains the implementation for the Node Health Check operator plugin [2]. This operator is responsible for configuring and monitoring the Node Health Check feature, which detects unhealthy nodes and triggers remediation workflows [2][5]. Both directories serve as infrastructure-as-code modules within the Assisted Service to automate the lifecycle management of these specific OpenShift operators during cluster installation [1][2][3].
Citations:
- 1: https://github.com/openshift/assisted-service/blob/master/internal/operators/cnv/cnv_operator.go
- 2: openshift/assisted-service@dda97d9
- 3: openshift/assisted-service@6dc4a31
- 4: openshift/assisted-service@da68432
- 5: https://docs.redhat.com/en/documentation/workload_availability_for_red_hat_openshift/25.9/html/remediation_fencing_and_maintenance/node-health-check-operator
🏁 Script executed:
set -euo pipefail
echo "===== occurrences of internal/operators/cnv in ci-operator configs ====="
rg -n --glob 'ci-operator/config/**/*.yaml' 'internal/operators/cnv' ci-operator/config | sed -n '1,120p'
echo "===== occurrences of internal/operators/cnv/.* in ci-operator configs ====="
rg -n --glob 'ci-operator/config/**/*.yaml' 'internal/operators/cnv/\\.\\*' ci-operator/config | sed -n '1,120p'Repository: openshift/release
Length of output: 3097
Match the CNV subtree in the change filter.
internal/operators/cnv matches only the literal path, so changes under internal/operators/cnv/... won’t trigger this job. Change it to internal/operators/cnv/.* in:
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml#L267-L271ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml#L267-L271
📍 Affects 2 files
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml#L267-L271(this comment)ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml#L267-L271
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml`
around lines 267 - 271, Update the pipeline_run_if_changed filter for
e2e-metal-assisted-virtualization-4-18 to match the entire CNV subtree by
changing the CNV pattern from the literal path to the path followed by .*. Apply
this change in
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.46.yaml
lines 267-271 and
ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.48.yaml
lines 267-271.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
Summary by CodeRabbit
assisted-servicerepository in the OpenShift CI pipeline controller.MGMT-24835; its target version still needs to be set to5.0.0.