Skip to content

MGMT-24835: configuring the auto mode for assisted-image-service#82067

Draft
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-image-service
Draft

MGMT-24835: configuring the auto mode for assisted-image-service#82067
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-image-service

Conversation

@andrej1991

@andrej1991 andrej1991 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Summary by CodeRabbit

  • Enables auto mode for the openshift/assisted-image-service repository in the pipeline controller.
  • Updates its generated CI configurations so selected end-to-end jobs are opt-in and only run when required, using always_run: false and pipeline_skip_if_only_changed.
  • Applies this gating to e2e-metal-assisted, e2e-ai-operator-ztp, and related versioned release pipelines while preserving existing skip patterns and capabilities.

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@andrej1991: This pull request references MGMT-24835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8c4aac4f-1b25-4fbb-98d9-32ba3cb8aef0

📥 Commits

Reviewing files that changed from the base of the PR and between 09f53e7 and 7f07ed2.

⛔ Files ignored due to path filters (21)
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-assisted-version-placeholder-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.11-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.12-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.13-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.14-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.15-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.16-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.17-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.42-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.43-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.45-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.46-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.47-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.48-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.49-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.50-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.51-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.52-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.53-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.54-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (22)
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-assisted-version-placeholder.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-main__edge.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.11.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.12.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.13.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.14.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.15.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.16.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-2.17.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.42.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.43.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.45.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.46.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.47.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.48.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.49.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.50.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.51.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.52.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.53.yaml
  • ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.54.yaml
  • core-services/pipeline-controller/config.yaml

Walkthrough

The PR updates assisted image service CI test gating across placeholder, edge, release, and version configurations, adding always_run: false and replacing skip_if_only_changed with pipeline_skip_if_only_changed. It also enables automatic pipeline-controller triggering for the repository.

Changes

Assisted image service CI configuration

Layer / File(s) Summary
Repository trigger enrollment
core-services/pipeline-controller/config.yaml
Adds assisted-image-service to the OpenShift repositories with automatic triggering enabled.
Main and release pipeline gating
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-main__edge.yaml, ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-release-ocm-*.yaml
Updates e2e-metal-assisted-5-0 and e2e-ai-operator-ztp entries with always_run: false and pipeline_skip_if_only_changed, preserving existing patterns and capabilities.
Version pipeline gating
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.*.yaml, ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-assisted-version-placeholder.yaml
Updates e2e-metal-assisted entries with the new pipeline-level skip key and explicit always_run: false.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: enabling auto mode for assisted-image-service.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only changes CI YAML and pipeline-controller config.
Test Structure And Quality ✅ Passed The PR only changes 43 YAML CI/config files; no Go or other Ginkgo test source was modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only CI/pipeline YAML changed; no Ginkgo test sources or test bodies were added or modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests were added or changed; the diff is CI/pipeline-controller YAML only, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI/pipeline config changed; no deployment manifests, operator code, or controllers were modified, so no topology-sensitive scheduling was introduced.
Ote Binary Stdout Contract ✅ Passed All 43 changed files are YAML CI/pipeline configs; no OTE source, main, init, or suite-setup code changed, so stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Diff only changes CI/pipeline YAML; no new Ginkgo e2e test code or IP/network logic was added, so the check is not applicable.
No-Weak-Crypto ✅ Passed Touched files are CI/pipeline YAML only; exact weak-crypto token scan over all changed files and diff found 0 hits.
Container-Privileges ✅ Passed The PR only changes CI skip/trigger settings and repo auto mode; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes CI/pipeline YAML; no new logging or secret/PII output was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrej1991
Once this PR has been reviewed and has the lgtm label, please assign droslean, eliorerz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants