Skip to content

MGMT-24835: configuring the auto mode for assisted-installer#82079

Draft
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-installer
Draft

MGMT-24835: configuring the auto mode for assisted-installer#82079
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-installer

Conversation

@andrej1991

@andrej1991 andrej1991 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Summary by CodeRabbit

  • Configures the assisted-installer repository for automatic CI triggering.
  • Updates assisted-installer CI jobs so inexpensive checks run first, with required jobs starting after they pass.
  • Applies consistent pipeline-level skip conditions and explicit always_run: false settings across e2e job definitions.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@andrej1991: This pull request references MGMT-24835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrej1991
Once this PR has been reviewed and has the lgtm label, please assign bear-redhat, crystalchun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7b01ee8f-01b1-45eb-bd35-873cedb6443a

📥 Commits

Reviewing files that changed from the base of the PR and between 86e6a39 and 96f18ae.

⛔ Files ignored due to path filters (21)
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-assisted-version-placeholder-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.11-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.12-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.13-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.14-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.15-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.16-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.17-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.42-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.43-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.45-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.46-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.47-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.48-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.49-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.50-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.51-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.52-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.53-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.54-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (23)
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-assisted-version-placeholder.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-master.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-master__edge.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.11.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.12.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.13.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.14.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.15.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.16.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-release-ocm-2.17.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.42.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.43.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.45.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.46.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.47.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.48.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.49.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.50.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.51.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.52.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.53.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.54.yaml
  • core-services/pipeline-controller/config.yaml

Walkthrough

The PR registers assisted-installer for automatic pipeline-controller triggering and updates assisted-installer CI test jobs to use pipeline-level skip conditions with explicit always_run: false.

Changes

Assisted Installer CI configuration

Layer / File(s) Summary
Pipeline controller repository registration
core-services/pipeline-controller/config.yaml
Adds assisted-installer to the automatically triggered repository list.
Test job gating migration
ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-*.yaml
Adds always_run: false and renames skip_if_only_changed to pipeline_skip_if_only_changed while preserving existing patterns and capabilities.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#81671: Applies the same CI job-stanza migration to other component configurations.
  • openshift/release#82067: Applies the same job-definition migration and adds automatic triggering for an assisted-service repository.
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: configuring auto mode for assisted-installer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes CI/pipeline YAML; no Ginkgo test definitions or titles were modified, so there are no unstable test names to flag.
Test Structure And Quality ✅ Passed Diff is config-only (44 YAML files) with no Go/Ginkgo test code, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: The PR only changes CI/job YAML (44 .yaml files) and adds no Go/Ginkgo test code, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS — the commit only changes CI/presubmit YAML and pipeline auto-mode config; no Go/Ginkgo e2e tests were added, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only changes CI job configs and a pipeline-controller repo trigger; no deployment manifests, operator code, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only CI YAML configs changed; no main/suite binary code was touched, so no stdout contract violation is introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes CI YAML/pipeline config; no new Ginkgo tests or external connectivity code was added.
No-Weak-Crypto ✅ Passed Touched files are CI YAML only; exact scan found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto usage.
Container-Privileges ✅ Passed The diff only changes CI job gating/trigger mode; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed Changed files only adjust CI job gating (always_run, pipeline_skip_if_only_changed); no new logging of secrets or PII appears in the diffs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants