Skip to content

MGMT-24835: configuring the auto mode for assisted-installer-agent#82085

Draft
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-installer-agent
Draft

MGMT-24835: configuring the auto mode for assisted-installer-agent#82085
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:auto-mode-assisted-installer-agent

Conversation

@andrej1991

@andrej1991 andrej1991 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Summary by CodeRabbit

  • Configures OpenShift CI infrastructure to automatically trigger pipelines for the assisted-installer-agent repo via core-services/pipeline-controller, with inexpensive checks as the initial gate before required (heavier) jobs run.
  • Updates the generated Prow/CI job definitions for assisted-installer-agent across master/edge, release OCM versions, and multiple v2.xx configs so key test jobs (e.g., subsystem-test, e2e-metal-assisted, e2e-ai-operator-ztp) are conditionally skipped unless relevant files change by:
    • setting always_run: false
    • renaming the change-filter control from skip_if_only_changed to pipeline_skip_if_only_changed (preserving the existing regex logic)
  • Tightens branch protection for openshift/assisted-installer-agent by requiring manually triggered jobs (require_manually_triggered_jobs: true).
  • References Jira issue MGMT-24835, which the CI robot noted has no target version configured even though the target branch expects version 5.0.0.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@andrej1991: This pull request references MGMT-24835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Assisted-installer-agent CI configurations now use pipeline_skip_if_only_changed and explicit always_run: false settings across branch, edge, release, placeholder, and version jobs. Pipeline-controller auto-triggering and manually triggered job requirements were also added.

Changes

CI job gating migration

Layer / File(s) Summary
Migrate assisted-installer-agent job gating
ci-operator/config/openshift/assisted-installer-agent/*
Updated assisted-installer-agent job definitions with always_run: false and renamed skip_if_only_changed to pipeline_skip_if_only_changed, preserving existing job patterns and execution settings.
Configure repository automation
core-services/pipeline-controller/config.yaml, core-services/prow/02_config/openshift/assisted-installer-agent/_prowconfig.yaml
Added automatic pipeline triggering and required manually triggered jobs for the repository.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Diff only changes CI/job YAML and branch-protection config; no Ginkgo test titles or dynamic test-name construction were introduced.
Test Structure And Quality ✅ Passed No Go/Ginkgo test files changed; the PR only updates CI/prow YAML configs, so the Ginkgo test-structure review is not applicable.
Microshift Test Compatibility ✅ Passed PR diff only changes CI/prow YAML; no Go or Ginkgo test files were added, so MicroShift test compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes CI/prow YAML in config dirs; no Go/Ginkgo test files were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR only changes CI/Prow config and pipeline trigger settings; no deployment/operator/controller code or scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed No process-level code changed; the PR only updates CI/pipeline YAML, so it doesn't introduce stdout writes in OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new or modified Ginkgo test code was added; the PR only updates CI/job YAML and branch-trigger config, so the IPv4/public-network test check is not applicable.
No-Weak-Crypto ✅ Passed Changed files are CI YAML only; exact searches found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret-comparison code.
Container-Privileges ✅ Passed Touched YAMLs only adjust CI/job gating; no changed file contains privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation or root settings.
No-Sensitive-Data-In-Logs ✅ Passed Changed files are CI/pipeline YAML only; added lines are job/trigger config, and scans found no new passwords, tokens, PII, hostnames, or logging statements.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: configuring auto mode for assisted-installer-agent.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrej1991
Once this PR has been reviewed and has the lgtm label, please assign danmanor, hector-vido for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants