Restore Alt+drag rectangular selection in the editor (#9864, #10029)

[dpage]

Summary

Fixes #9864 and #10029.

The fix for #9570 (commit 3598840) stopped Alt+F5 from showing a crosshair cursor, but did so by changing the editor's rectangular-selection eventFilter to require Alt+Ctrl and moving the crosshair cue to Control. That broke the long-standing Alt+drag block/column selection (reported in #9864 and #10029) and left the crosshair cue inconsistent with the actual gesture.

Fix: restore the default rectangularSelection() (Alt+drag) and remove crosshairCursor entirely.

• Brings back block selection that users relied on (pgAdmin 9.14 the column selection (Alt/Option + right mouse) drag no longer work #9864, In Editor Control + Mouse to Highlight blocks of text now missing entirely. #10029).
• Keeps ALT + F5 not running selected query #9570's intent: the crosshair no longer appears when Alt is held (e.g. for Alt+F5). The crosshair-on-Alt was the ALT + F5 not running selected query #9570 artifact, and CodeMirror's crosshairCursor only keys off a held modifier (it can't be limited to an active drag), so dropping it is the clean reconciliation.

Changes

• Editor.jsx: rectangularSelection() restored; crosshairCursor import + usage removed.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation

  • Added pgAdmin 4 v9.16 release notes documenting updates and improvements, including support for PostgreSQL and EDB Advanced Server with bundled PostgreSQL utilities version 18.2.

• Bug Fixes

  • Fixed regression affecting rectangular text selection in the code editor.

[coderabbitai]

Warning

Review limit reached

@dpage, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 18 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c5b7908-3302-41fc-b6be-cb42e86e8720

📥 Commits

Reviewing files that changed from the base of the PR and between 435a1d0 and 09fe9d6.

📒 Files selected for processing (2)

• docs/en_US/release_notes_9_16.rst
• web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx

Walkthrough

The pull request fixes rectangular text selection behavior in the CodeMirror code editor by removing the crosshairCursor configuration and making rectangularSelection() unconditional. It then documents this fix and other v9.16 release information in new release notes.

Changes

v9.16 Release Notes and Rectangular Selection Fix

Layer / File(s)	Summary
Rectangular selection configuration fix web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx	crosshairCursor is removed from imports, and rectangularSelection() changes from a conditional call (filtering for alt+ctrl keys) to an unconditional call. Comments explain the intentional omission of crosshairCursor to preserve the block-selection fix.
v9.16 Release Notes docs/en_US/release_notes.rst, docs/en_US/release_notes_9_16.rst	Release notes for v9.16 are initialized with document structure, metadata (header, TBD release date, scope), supported database servers, bundled PostgreSQL utilities (v18.2), section headings for features, and a bug fixes entry documenting Issue #9864's rectangular selection fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• pgadmin-org/pgadmin4#9763: Both PRs modify rectangular selection and crosshairCursor configuration in the same Editor.jsx file, with this PR removing crosshairCursor entirely and the prior PR initially adjusting the selection filter and crosshairCursor scope.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: restoring Alt+drag rectangular selection in the editor, which is the primary focus of the code changes in Editor.jsx.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Restores the CodeMirror editor’s longstanding Alt/Option+drag rectangular (column) selection gesture that was regressed by the earlier #9570 fix, while keeping the “no crosshair cursor when Alt is held” behavior.

Changes:

• Restore default rectangularSelection() behavior (Alt/Option+drag) in the editor.
• Remove crosshairCursor usage so holding Alt (e.g., for Alt+F5) no longer shows a crosshair cue.
• Add v9.16 release note entry for the regression fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx	Restores default rectangular selection gesture and removes crosshair cursor extension.
docs/en_US/release_notes_9_16.rst	Documents the rectangular selection regression fix in v9.16 release notes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.