Skip to content

Restore Alt+drag rectangular selection in the editor (#9864, #10029) #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpage wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

Restore Alt+drag rectangular selection in the editor (#9864, #10029) #10043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/en_US/release_notes_9_16.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ Housekeeping

Bug fixes
*********

| `Issue #9864 <https://github.com/pgadmin-org/pgadmin4/issues/9864>`_ - Fixed a regression where the rectangular (block/column) text selection in the code editor stopped working; restored the default Alt+drag selection without re-introducing the crosshair cursor on Alt+F5 (#9570).
9 changes: 6 additions & 3 deletions web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {
drawSelection,
dropCursor,
rectangularSelection,
crosshairCursor,
highlightActiveLine,
EditorView,
keymap,
Expand Down Expand Up @@ -120,8 +119,12 @@ function insertTabWithUnit({ state, dispatch }) {
const defaultExtensions = [
highlightSpecialChars(),
dropCursor(),
rectangularSelection({ eventFilter: (e) => e.altKey && e.ctrlKey }),
crosshairCursor({ key: 'Control' }),
// rectangularSelection() restores the default Alt+drag block (column)
// selection. crosshairCursor is intentionally not used: it displayed a
// crosshair cursor whenever Alt was held - including for the Alt+F5 run
// shortcut (#9570). Omitting it keeps that fix while restoring the block
// selection that was lost. #9864 #10029
rectangularSelection(),
EditorState.allowMultipleSelections.of(true),
indentOnInput(),
syntaxHighlighting,
Expand Down
Loading