Fix method call on unioned class type analysis is broken#5225
Merged
VincentLanglet merged 5 commits intophpstan:2.1.xfrom Mar 25, 2026
Merged
Conversation
VincentLanglet
force-pushed
the
create-pull-request/patch-8y7mxaj
branch
from
cb2e144 to
bc9e8c4
Compare
- In UnionType::getUnresolvedMethodPrototype(), stopped overriding each member's calledOnType with the full union for non-template unions - Template union types (TemplateUnionType, TemplateBenevolentUnionType) still propagate the union as calledOnType to preserve template identity - Updated existing test assertion in static-late-binding.php - Added regression test tests/PHPStan/Analyser/nsrt/bug-11687.php Closes phpstan/phpstan#11687
Closes phpstan/phpstan#12562 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Automated fix attempt 1 for CI failures.
Automated fix attempt 2 for CI failures.
VincentLanglet
force-pushed
the
create-pull-request/patch-8y7mxaj
branch
from
bc9e8c4 to
eae15bb
Compare
Contributor
Author
|
I think this test is better than #5299 |
staabm
reviewed
Mar 25, 2026
| */ | ||
| class Collection | ||
| { | ||
| /** |
Contributor
There was a problem hiding this comment.
this file mixes tabs and spaces for indent
staabm
approved these changes
Mar 25, 2026
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #4960
Fixes phpstan/phpstan#11687
Closes phpstan/phpstan#12562
Fixes phpstan/phpstan#14203