Skip to content

gh-146625: fix module suggestions when using -S#146626

Open
Locked-chess-official wants to merge 4 commits intopython:mainfrom
Locked-chess-official:improve_module_suggestion_logic
Open

gh-146625: fix module suggestions when using -S#146626
Locked-chess-official wants to merge 4 commits intopython:mainfrom
Locked-chess-official:improve_module_suggestion_logic

Conversation

@Locked-chess-official
Copy link
Copy Markdown
Contributor

@Locked-chess-official Locked-chess-official commented Mar 30, 2026

@picnixz picnixz changed the title gh-146625: fix bug in suggest module gh-146625: fix module suggestions when using -S Mar 30, 2026
Copy link
Copy Markdown
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the changes. In this PR, only fix the -S behavior and add tests. In a separate, create a finder that would raise and add a test.

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 30, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Locked-chess-official
Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 30, 2026

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from picnixz March 30, 2026 10:05
Copy link
Copy Markdown
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the PR. As I do not have much time this week, I'll let someone else review it (don't forget the NEWS entry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants