[ET-VK][custom_ops] Standardize binary filenames to test_*.cpp#19571
Merged
Conversation
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors: - add.cpp -> test_add.cpp - choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp - q4gsw_linear.cpp -> test_q4gsw_linear.cpp - q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp - q8csw_linear.cpp -> test_q8csw_linear.cpp Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves). Updates to references: - targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary. - CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename). - tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries. - tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d). - fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary. Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/) [ghstack-poisoned]
This was referenced May 13, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19571
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ You can merge normally! (2 Unrelated Failures), 1 Unclassified FailureAs of commit af27deb with merge base 1992bdd ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
GregoryComer
approved these changes
May 13, 2026
ee4b173
into
gh/SS-JIA/535/base
172 of 185 checks passed
SS-JIA
pushed a commit
that referenced
this pull request
May 14, 2026
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors: - add.cpp -> test_add.cpp - choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp - q4gsw_linear.cpp -> test_q4gsw_linear.cpp - q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp - q8csw_linear.cpp -> test_q8csw_linear.cpp Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves). Updates to references: - targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary. - CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename). - tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries. - tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d). - fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary. Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/) ghstack-source-id: 381655469 Pull Request resolved: #19571
SS-JIA
pushed a commit
that referenced
this pull request
May 14, 2026
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors: - add.cpp -> test_add.cpp - choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp - q4gsw_linear.cpp -> test_q4gsw_linear.cpp - q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp - q8csw_linear.cpp -> test_q8csw_linear.cpp Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves). Updates to references: - targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary. - CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename). - tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries. - tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d). - fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary. Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/) ghstack-source-id: 381655469 Pull Request resolved: #19571
SS-JIA
pushed a commit
that referenced
this pull request
May 14, 2026
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors: - add.cpp -> test_add.cpp - choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp - q4gsw_linear.cpp -> test_q4gsw_linear.cpp - q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp - q8csw_linear.cpp -> test_q8csw_linear.cpp Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves). Updates to references: - targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary. - CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename). - tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries. - tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d). - fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary. Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/) ghstack-source-id: 381655469 Pull Request resolved: #19571
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:
Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).
Updates to references:
Differential Revision: D105059945