Skip to content

[ET-VK][custom_ops] Standardize binary filenames to test_*.cpp#19571

Merged
meta-codesync[bot] merged 1 commit into
gh/SS-JIA/535/basefrom
gh/SS-JIA/535/head
May 14, 2026
Merged

[ET-VK][custom_ops] Standardize binary filenames to test_*.cpp#19571
meta-codesync[bot] merged 1 commit into
gh/SS-JIA/535/basefrom
gh/SS-JIA/535/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented May 13, 2026

Stack from ghstack (oldest at bottom):

Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:

  • add.cpp -> test_add.cpp
  • choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp
  • q4gsw_linear.cpp -> test_q4gsw_linear.cpp
  • q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp
  • q8csw_linear.cpp -> test_q8csw_linear.cpp

Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).

Updates to references:

  • targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary.
  • CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename).
  • tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries.
  • tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d).
  • fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary.

Differential Revision: D105059945

Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:

- add.cpp -> test_add.cpp
- choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp
- q4gsw_linear.cpp -> test_q4gsw_linear.cpp
- q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp
- q8csw_linear.cpp -> test_q8csw_linear.cpp

Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).

Updates to references:

- targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary.
- CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename).
- tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries.
- tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d).
- fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary.

Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19571

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ You can merge normally! (2 Unrelated Failures), 1 Unclassified Failure

As of commit af27deb with merge base 1992bdd (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2026
@meta-codesync meta-codesync Bot merged commit ee4b173 into gh/SS-JIA/535/base May 14, 2026
172 of 185 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/535/head branch May 14, 2026 01:56
@meta-codesync meta-codesync Bot temporarily deployed to cherry-pick-bot May 14, 2026 01:56 Inactive
SS-JIA pushed a commit that referenced this pull request May 14, 2026
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:

- add.cpp -> test_add.cpp
- choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp
- q4gsw_linear.cpp -> test_q4gsw_linear.cpp
- q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp
- q8csw_linear.cpp -> test_q8csw_linear.cpp

Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).

Updates to references:

- targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary.
- CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename).
- tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries.
- tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d).
- fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary.

Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/)

ghstack-source-id: 381655469
Pull Request resolved: #19571
SS-JIA pushed a commit that referenced this pull request May 14, 2026
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:

- add.cpp -> test_add.cpp
- choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp
- q4gsw_linear.cpp -> test_q4gsw_linear.cpp
- q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp
- q8csw_linear.cpp -> test_q8csw_linear.cpp

Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).

Updates to references:

- targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary.
- CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename).
- tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries.
- tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d).
- fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary.

Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/)

ghstack-source-id: 381655469
Pull Request resolved: #19571
SS-JIA pushed a commit that referenced this pull request May 14, 2026
Five custom_ops test binaries did not follow the test_*.cpp naming convention used by the other 16. Rename them via sl mv (history-preserving) in both xplat and fbcode mirrors:

- add.cpp -> test_add.cpp
- choose_qparams_per_row.cpp -> test_choose_qparams_per_row.cpp
- q4gsw_linear.cpp -> test_q4gsw_linear.cpp
- q8csw_conv2d.cpp -> test_q8csw_conv2d.cpp
- q8csw_linear.cpp -> test_q8csw_linear.cpp

Also add a Buck target for test_q8ta_unary -- the source file existed but no target was defined, leaving the binary unbuildable in fbsource (xplat/executorch/backends/vulkan/test/custom_ops:test_q8ta_unary now resolves).

Updates to references:

- targets.bzl (xplat + fbcode mirrors) -- five define_custom_op_test_binary() call sites renamed; one new entry for test_q8ta_unary.
- CMakeLists.txt (xplat + fbcode mirrors) -- five add_operator_prototype() call sites renamed. test_q8ta_unary is not added to CMake here since it was not in the prior CMake list (existing latent gap; orthogonal to this rename).
- tools/skycastle/.../executorch_vulkan_eureka_unit_tests.sky -- four CI target paths updated. Display labels are also updated to match the binary name (test_q8csw_linear, etc.), consistent with the convention used by adjacent test_q8ta_* entries.
- tools/skycastle/.../executorch_vulkan_gpu_host_unit_tests.sky -- three CI target paths + labels updated (this file does not run q8csw_conv2d).
- fbcode/executorch/oss/.github/workflows/pull.yml + xplat mirror -- five OSS CI references updated, including the build_and_run.sh argument that runs the renamed test_add binary.

Differential Revision: [D105059945](https://our.internmc.facebook.com/intern/diff/D105059945/)

ghstack-source-id: 381655469
Pull Request resolved: #19571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants