Several fixes for the CI scripts#2276
Conversation
The commit abd128c ("Revert "ci: add git_ref input to reusable build workflows"") dropped git_ref input to the build-yocto workflow. Follow that change and drop the invalid input usage from the workflow. Fixes: 8cb4e6b ("ci: build-yocto: add github-cache based build skip mechanism") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
The test-distro workflow doesn't have 'distro' input. Use 'inputs.distro_name' for the job name. Fixes: f522791 ("workflows: refactor test workflow") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Even though the 'Test PR' workflow is being triggered by the workflow runs in the correct branch, the 'Test PR' is still being triggered against the default branch. This was not a problem until the commit 3ac51cf ("ci: switch qcom-distro tests to linux-qcom-next kernel") which created a mismatch between artifacts in the wrynose branch and the expectations of the test worfklows in the master branch. Specify the Git ref to be used to checkout the testing actions and specify it explictly for the 'Test PR' workflows, extracting the info from the GitHub event. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Test Results 103 files ± 0 632 suites ±0 5h 28m 15s ⏱️ - 1h 20m 25s For more details on these failures, see this check. Results for commit 28f29fb. ± Comparison against base commit c66b499. This pull request removes 2 tests. |
|
Colleagues, Without the last fix backported to the wrynose branch, the tests are not being executed / reported correctly. |
mwasilew
left a comment
There was a problem hiding this comment.
I think this might open the door for running workflows in the context of different repository than meta-qcom. TBH I don't know how to test this properly and make sure it doesn't allow to run tests from random forks in our LAB. I'll try to figure something out today.
|
I tried this change and I'm still getting the version of the workflow from |
|
It doesn't seem to be possible to trigger the branch specific workflow with I skipped the redundant keys. |
Do you have a contents of |
We're saving |
I don't see events for the 'Test PR build' workflows. |
|
The event file is saved in build workflow as it's called in the context of PR. Test workflow is executed in the context of main repository so it needs to learn about the PR from this file. |
I'm thinking about the |
The 'Test PR' workflow ends up being executed in the master branch context, checking it our for the for the actions execution. This broke now as the wrynose branch deviated from the master in the terms of the generated artifacts. Test PR now fails to execute testes for the wrynose branch.