platforms/iq-x7181-evk: fix duplicate uefi_dtb_a partition name#118
Open
GuanquanTian wants to merge 1 commit into
Open
platforms/iq-x7181-evk: fix duplicate uefi_dtb_a partition name#118GuanquanTian wants to merge 1 commit into
GuanquanTian wants to merge 1 commit into
Conversation
GuanquanTian
force-pushed
the
iq-x7181-evk-fix-dup-uefi-dtb
branch
from
0ecc4a4 to
aead03f
Compare
Rename the second uefi_dtb_a partition to uefi_dtb_b to match the A/B slot naming used elsewhere in this layout (dtb_a/dtb_b, uefisecapp_a/ uefisecapp_b, etc.). Signed-off-by: guanquan <guanquan@qti.qualcomm.com>
GuanquanTian
force-pushed
the
iq-x7181-evk-fix-dup-uefi-dtb
branch
from
aead03f to
dcf2d37
Compare
Contributor
|
Can you add a check to prevent similar errors in the future? |
Author
|
Okay, will do. While investigating whether to add a CI check for duplicate partition names , I found another instance of the same class of bug: platforms/glymur-crd/spinor/partitions.conf declares SYSFW_VERSION twice within the same physical partition (LUN 0): #line 54 #line 74 Should we delete a certain line? But it may cause changes in the address offset of the partition table |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uefi_dtb_a(with different type GUIDs), which is invalid.uefi_dtb_bto match the A/B slot naming used elsewhere in this layout (dtb_a/dtb_b,uefisecapp_a/uefisecapp_b, etc.).