Fix placeholder visibility inheritance#1237
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Walkthrough
ChangesPlaceholder 可见性修复
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 31 31
Lines 1271 1271
Branches 444 464 +20
=======================================
Hits 1264 1264
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zombieJ
left a comment
There was a problem hiding this comment.
Looks good to me. The placeholder no longer forces visibility: visible, preserving parent visibility inheritance while keeping the hidden placeholder path covered.
变更内容
visibility: visible,让其继承父级visibility。visibility: hidden行为。visibility: hidden的回归测试,并更新相关快照。修复原因
关联 ant-design/ant-design#58567。TreeSelect/Select 外层设置
visibility: hidden时,placeholder 内联visibility: visible会覆盖父级隐藏状态,导致 placeholder 仍可见。验证
npm test通过(21 suites / 428 tests)npm run lint -- --quiet通过git diff --check通过npm run tsc未通过:本地node_modules缺少 package.json 中声明的 devDependency@rc-component/dialog,报错位置是docs/examples/getPopupContainer.tsx,与本次改动无关。Summary by CodeRabbit