Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SelectInput/Content/Placeholder.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function Placeholder(props: PlaceholderProps) {
<div
className={clsx(`${prefixCls}-placeholder`, classNames?.placeholder)}
style={{
visibility: show ? 'visible' : 'hidden',
...(show ? {} : { visibility: 'hidden' }),
...styles?.placeholder,
}}
>
Expand Down
2 changes: 0 additions & 2 deletions tests/__snapshots__/Combobox.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ exports[`Select.Combobox renders controlled correctly 1`] = `
>
<div
class="rc-select-placeholder"
style="visibility: visible;"
>
Search
</div>
Expand Down Expand Up @@ -37,7 +36,6 @@ exports[`Select.Combobox renders correctly 1`] = `
>
<div
class="rc-select-placeholder"
style="visibility: visible;"
>
Search
</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/__snapshots__/ssr.test.tsx.snap
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-content"><div class="rc-select-placeholder" style="visibility:visible"></div><input id="test-id" type="text" readonly="" autoComplete="new-password" class="rc-select-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-autocomplete="list" value=""/></div></div>"`;
exports[`Select.SSR should work 1`] = `"<div class="rc-select rc-select-single"><div class="rc-select-content"><div class="rc-select-placeholder"></div><input id="test-id" type="text" readonly="" autoComplete="new-password" class="rc-select-input" role="combobox" aria-expanded="false" aria-haspopup="listbox" aria-autocomplete="list" value=""/></div></div>"`;
13 changes: 13 additions & 0 deletions tests/placeholder.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ describe('Select placeholder', () => {
});
});

it('should not force placeholder visible when select is hidden', () => {
const { container } = render(<Select style={{ visibility: 'hidden' }} placeholder="bamboo" />);
const placeholder = container.querySelector<HTMLElement>('.rc-select-placeholder')!;

expect(container.querySelector('.rc-select')).toHaveStyle({
visibility: 'hidden',
});
expect(placeholder).not.toHaveAttribute(
'style',
expect.stringContaining('visibility: visible'),
);
});

it('when value is null', () => {
const { container } = render(<Select value={null} placeholder="bamboo" />);
expect(container.querySelector('.rc-select-placeholder')).toBeTruthy();
Expand Down
Loading