Add specs for Method#original_name and #inspect with Kernel methods#1356
Merged
Conversation
sampokuokkanen
added a commit
to sampokuokkanen/jruby
that referenced
this pull request
May 12, 2026
Fix Method#original_name and #inspect when two methods share a wrapper (like is_a?/kind_of?) Introduce sourceName on DynamicMethod to preserve a method's source name when methods share a single underlying wrapper. Set it in RubyModule when binding, walk the alias chain in AliasMethod#getOldName to reach it, and consult it from Method#original_name and #inspect so both report the correct source name instead of whichever name happened to live on the wrapper. Covered by new specs in ruby/spec#1356 (ruby/spec#1356).
sampokuokkanen
added a commit
to sampokuokkanen/jruby
that referenced
this pull request
May 12, 2026
Fix Method#original_name and #inspect when two methods share a wrapper (like is_a?/kind_of?) Introduce sourceName on DynamicMethod to preserve a method's source name when methods share a single underlying wrapper. Set it in RubyModule when binding, walk the alias chain in AliasMethod#getOldName to reach it, and consult it from Method#original_name and #inspect so both report the correct source name instead of whichever name happened to live on the wrapper. Covered by new specs in ruby/spec#1356 (ruby/spec#1356).
headius
approved these changes
May 12, 2026
Contributor
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
This looks fine to me and fills a gap in specs.
headius
requested changes
May 12, 2026
Contributor
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Actually, two small changes here would clean this up and we can merge.
sampokuokkanen
force-pushed
the
original-name-and-inspect
branch
from
b1a7c91 to
03ed56a
Compare
eregon
requested changes
May 13, 2026
| def original_method; end | ||
| alias_method :renamed_method, :original_method | ||
| end | ||
| klass.new.method(:renamed_method).send(@method).should =~ /#renamed_method\(original_method\)/ |
Member
There was a problem hiding this comment.
Suggested change
| klass.new.method(:renamed_method).send(@method).should =~ /#renamed_method\(original_method\)/ | |
| klass.new.method(:renamed_method).send(@method).should.include? '#renamed_method(original_method)' |
|
|
||
| it "shows the source UnboundMethod's name in parentheses for a define_method'd method" do | ||
| klass = Class.new { define_method(:renamed_is_a?, ::Kernel.instance_method(:is_a?)) } | ||
| klass.new.method(:renamed_is_a?).send(@method).should =~ /#renamed_is_a\?\(is_a\?\)/ |
Member
There was a problem hiding this comment.
Same, .should.include? is much easier to read by avoiding escaping.
Same below
Comment on lines
+96
to
+97
| Object.new.method(:is_a?).send(@method).should_not =~ /\(kind_of\?\)/ | ||
| Object.new.method(:kind_of?).send(@method).should_not =~ /\(is_a\?\)/ |
|
|
||
| it "shows the source name when aliasing a define_method'd Kernel method" do | ||
| klass = Class.new do | ||
| define_method(:is_a?, ::Kernel.instance_method(:is_a?)) |
Member
There was a problem hiding this comment.
I think it'd be good to give this one another name for clarity and to make it more interesting
Comment on lines
+45
to
+46
| klass = Class.new { define_method(:is_a?, ::Kernel.instance_method(:is_a?)) } | ||
| klass.new.method(:is_a?).original_name.should == :is_a? |
Member
There was a problem hiding this comment.
Give the new method another name otherwise this doesn't test anything, same below
|
|
||
| it "preserves the source name when aliasing a define_method'd Kernel method" do | ||
| klass = Class.new do | ||
| define_method(:is_a?, ::Kernel.instance_method(:is_a?)) |
Member
There was a problem hiding this comment.
Same, this should have another name
| UnboundMethodSpecs::A.instance_method(:baz).send(@method).should.start_with? "#<UnboundMethod: UnboundMethodSpecs::A#baz" | ||
| end | ||
|
|
||
| it "shows the original name in parentheses for an aliased method" do |
Member
There was a problem hiding this comment.
This duplication for UnboundMethod is not ideal. One way to fix it would be to use a separate shared spec describe, require it from both specs and pass a lambda as @object, for Method it's just be identity and for UnboundMethod it'd be -> meth { meth.unbind }.
This is a bigger/trickier change though so if you don't feel comfortable with it I think it's OK to keep the duplication in this PR.
Contributor
Author
There was a problem hiding this comment.
Thank you! That did make tests look much nicer.
Adds specs for Method#original_name and #inspect when define_method or alias is used with Kernel#is_a? / Kernel#kind_of? methods that can share an internal implementation in some Ruby implementations. Existing specs didn't catch when introspection leaked the shared internal name.
sampokuokkanen
force-pushed
the
original-name-and-inspect
branch
from
03ed56a to
5f21795
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds specs for Method#original_name and #inspect when define_method or alias is used with Kernel#is_a? / Kernel#kind_of? methods that can share an internal implementation in some Ruby implementations. Existing specs didn't catch when introspection leaked the shared internal name.
Also documents inspect's behavior on aliased methods, which wasn't previously covered.
Continuing the work started in #1353 and adding specs that fail at least on JRuby. (the specs added in that PR now pass on JRuby master though!)