Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/method/inspect_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
require_relative '../../spec_helper'
require_relative 'shared/to_s'
require_relative 'shared/aliased_inspect'

describe "Method#inspect" do
it_behaves_like :method_to_s, :inspect
it_behaves_like :method_to_s_aliased, :inspect, -> meth { meth }
end
16 changes: 16 additions & 0 deletions core/method/original_name_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,20 @@
klass.new.method(:renamed).original_name.should == :my_method
klass.new.method(:aliased).original_name.should == :my_method
end

it "returns the source UnboundMethod's name for Kernel#is_a? and Kernel#kind_of?" do
klass = Class.new { define_method(:my_is_a?, ::Kernel.instance_method(:is_a?)) }
klass.new.method(:my_is_a?).original_name.should == :is_a?

klass = Class.new { define_method(:my_kind_of?, ::Kernel.instance_method(:kind_of?)) }
klass.new.method(:my_kind_of?).original_name.should == :kind_of?
end

it "preserves the source name when aliasing a define_method'd Kernel method" do
klass = Class.new do
define_method(:my_is_a?, ::Kernel.instance_method(:is_a?))
alias_method :renamed_is_a?, :my_is_a?
end
klass.new.method(:renamed_is_a?).original_name.should == :is_a?
end
end
31 changes: 31 additions & 0 deletions core/method/shared/aliased_inspect.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
describe :method_to_s_aliased, shared: true do
# @object converts a bound Method to either a Method (identity) or an
# UnboundMethod (-> meth { meth.unbind }), so these expectations cover both
# Method#to_s/#inspect and UnboundMethod#to_s/#inspect.

it "shows the original name in parentheses for an aliased method" do
klass = Class.new do
def original_method; end
alias_method :renamed_method, :original_method
end
@object.call(klass.new.method(:renamed_method)).send(@method).should.include? '#renamed_method(original_method)'
end

it "shows the source UnboundMethod's name in parentheses for a define_method'd method" do
klass = Class.new { define_method(:renamed_is_a?, ::Kernel.instance_method(:is_a?)) }
@object.call(klass.new.method(:renamed_is_a?)).send(@method).should.include? '#renamed_is_a?(is_a?)'
end

it "does not annotate a directly looked-up Kernel method with a shared internal name" do
@object.call(Object.new.method(:is_a?)).send(@method).should_not.include? '(kind_of?)'
@object.call(Object.new.method(:kind_of?)).send(@method).should_not.include? '(is_a?)'
end

it "shows the source name when aliasing a define_method'd Kernel method" do
klass = Class.new do
define_method(:my_is_a?, ::Kernel.instance_method(:is_a?))
alias_method :renamed_is_a?, :my_is_a?
end
@object.call(klass.new.method(:renamed_is_a?)).send(@method).should.include? '#renamed_is_a?(is_a?)'
end
end
2 changes: 2 additions & 0 deletions core/method/to_s_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
require_relative '../../spec_helper'
require_relative 'shared/to_s'
require_relative 'shared/aliased_inspect'

describe "Method#to_s" do
it_behaves_like :method_to_s, :to_s
it_behaves_like :method_to_s_aliased, :to_s, -> meth { meth }
end
2 changes: 2 additions & 0 deletions core/unboundmethod/inspect_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
require_relative '../../spec_helper'
require_relative 'fixtures/classes'
require_relative 'shared/to_s'
require_relative '../method/shared/aliased_inspect'

describe "UnboundMethod#inspect" do
it_behaves_like :unboundmethod_to_s, :inspect
it_behaves_like :method_to_s_aliased, :inspect, -> meth { meth.unbind }
end
16 changes: 16 additions & 0 deletions core/unboundmethod/original_name_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,20 @@
klass.instance_method(:renamed).original_name.should == :my_method
klass.instance_method(:aliased).original_name.should == :my_method
end

it "returns the source UnboundMethod's name for Kernel#is_a? and Kernel#kind_of?" do
klass = Class.new { define_method(:my_is_a?, ::Kernel.instance_method(:is_a?)) }
klass.instance_method(:my_is_a?).original_name.should == :is_a?

klass = Class.new { define_method(:my_kind_of?, ::Kernel.instance_method(:kind_of?)) }
klass.instance_method(:my_kind_of?).original_name.should == :kind_of?
end

it "preserves the source name when aliasing a define_method'd Kernel method" do
klass = Class.new do
define_method(:my_is_a?, ::Kernel.instance_method(:is_a?))
alias_method :renamed_is_a?, :my_is_a?
end
klass.instance_method(:renamed_is_a?).original_name.should == :is_a?
end
end
2 changes: 2 additions & 0 deletions core/unboundmethod/to_s_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
require_relative '../../spec_helper'
require_relative 'fixtures/classes'
require_relative 'shared/to_s'
require_relative '../method/shared/aliased_inspect'

describe "UnboundMethod#to_s" do
it_behaves_like :unboundmethod_to_s, :to_s
it_behaves_like :method_to_s_aliased, :to_s, -> meth { meth.unbind }
end
Loading