resolve: Partially convert `ambiguous_glob_imports` lint into a hard error by petrochenkov · Pull Request #149195 · rust-lang/rust

petrochenkov · 2025-11-21T19:59:58Z

View all comments

I'm tired of this logic interfering with any attempts to fix or refactor glob imports.

Change description for lang team: #149195 (comment).
Part of #114095.

rustbot · 2025-11-21T20:00:02Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustbot · 2025-11-21T20:00:04Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

petrochenkov · 2025-11-21T20:00:34Z

@bors try

resolve: Convert `ambiguous_glob_imports` lint into a hard error

rust-bors · 2025-11-21T22:17:19Z

☀️ Try build successful (CI)
Build commit: 446cb60 (446cb600aa4837dd6c513f14fa0d25a909b177d7, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

petrochenkov · 2025-11-22T06:25:30Z

@craterbot check

craterbot · 2025-11-22T06:26:01Z

👌 Experiment pr-149195 created and queued.
🤖 Automatically detected try build 446cb60
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-11-29T06:16:09Z

🚧 Experiment pr-149195 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-12-01T01:30:28Z

🎉 Experiment pr-149195 is completed!
📊 2676 regressed and 6 fixed (741888 total)
📊 2000 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt ↩

nnethercote · 2025-12-01T02:09:47Z

@petrochenkov: seems like a lot of regressions :( Should I review this?

petrochenkov · 2025-12-01T04:34:18Z

@petrochenkov: seems like a lot of regressions :( Should I review this?

Not yet.
@rustbot author

rustbot · 2025-12-01T04:34:22Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

petrochenkov · 2025-12-01T15:20:07Z

The largest part of the regressions are from openssl-0.10.*, it's a known issue that is addressed by #147984.
So this is blocked by #147984 now.
@rustbot blocked

yaahc · 2025-12-09T23:18:31Z

Correct me if I'm wrong on this one

@rustbot author

petrochenkov · 2026-03-13T13:53:25Z

@bors try

petrochenkov · 2026-03-13T14:40:57Z

TODO: @craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149195-5/retry-regressed-list.txt

rust-bors · 2026-03-13T16:03:51Z

☀️ Try build successful (CI)
Build commit: d578b6c (d578b6cfee5b7dc31169715f836745f9e96213f1, parent: 8db65c71725664d85d06ec96ee3e575665de1f6a)

petrochenkov · 2026-03-13T17:18:07Z

@craterbot run mode=check-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-149195-5/retry-regressed-list.txt

craterbot · 2026-03-13T17:18:15Z

👌 Experiment pr-149195-6 created and queued.
🤖 Automatically detected try build d578b6c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-03-13T21:44:08Z

🚧 Experiment pr-149195-6 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-03-13T23:34:41Z

🎉 Experiment pr-149195-6 is completed!
📊 32 regressed and 0 fixed (237 total)
📊 41 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149195-6/retry-regressed-list.txt ↩

petrochenkov · 2026-03-19T16:07:33Z

Change description for lang team

This PR turns a subset of the ambiguous_glob_imports deprecation lint into a hard error.
The lint was implemented more than 2.5 years ago, and made deny-by-default and report-in-dependencies 8.5 months ago.

The exact affected subset is hard to describe, because it's very heuristic-based.
The heuristics are hard to maintain and are easily affected by any changes to import resolution, so removing them is the whole point of this PR.

It's easier to say what is still a lint and not a hard error:

Cross-crate cases recently added by resolve: Preserve ambiguous glob reexports in crate metadata #147984
Specific cases encountered in outdated versions of noise, rustybuzz and pdf, breaking them (especially noise) causes hundreds of regressions.
Anything else requiring only local reasoning (one import), and not heuristics based on analyzing whole import chains.

Crater run can be found in #149195 (comment).
It shows 31 non-spurious regressions, 9 of those are from an outdated version of ark-test-curves, and 5 more from outdated versions of sv-parser-parser.

yaahc · 2026-03-25T20:24:09Z

nick asked me to take over the review on this one

r? @yaahc

traviscross · 2026-04-08T16:42:58Z

This makes sense to me. It'd be good to continue down the path of cleaning this up. Thanks @petrochenkov for pushing this forward. Thanks @yaahc for taking this review.

@rfcbot fcp merge lang

rust-rfcbot · 2026-04-08T16:43:00Z

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

joshtriplett · 2026-04-08T16:49:42Z

Playground that confirms my understanding of a case that isn't an error: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=d5f27a39e4cd4e9bf0e0e2f994bea78f

(The only warning there is that the second prelude is unused, which is expected.)

My understanding is that this hard error won't affect that case, so 👍.

petrochenkov · 2026-04-29T20:11:04Z

ping @nikomatsakis @scottmcm @tmandry, it's been 3 weeks.

tmandry · 2026-05-06T18:00:40Z

@rfcbot reviewed

rust-rfcbot · 2026-05-06T18:00:55Z

🔔 This is now entering its final comment period, as per the review above. 🔔

joshtriplett · 2026-05-06T20:58:03Z

Is there an FCW that will get emitted if the crate-specific hacks get hit?

petrochenkov · 2026-05-07T04:24:47Z

Is there an FCW that will get emitted if the crate-specific hacks get hit?

Yes, ambiguous_glob_imports.
Crate-specific hacks in this case turn a hard error into the lint (which is deny-by-default and report-in-deps now).

rust-rfcbot · 2026-05-16T18:01:38Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

…error

rustbot · 2026-05-16T19:00:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-05-16T19:02:23Z

@rustbot ready
r? @mu001999

mu001999

@rustbot author

View changes since this review

mu001999 · 2026-05-17T06:29:28Z

    /// ### Example
    ///
-    /// ```rust,compile_fail
+    /// ```rust,ignore (needs extern crate)


This example and the explanation below it are outdated. Is there a more suitable example that demonstrates the current lint behavior?

mu001999 · 2026-05-17T07:51:36Z

+            && self.def_path_str(def_id2).ends_with("ggg::Class")
+    }
+
+    fn is_pdf_0_9_0(&self, old_glob_decl: Decl<'ra>, glob_decl: Decl<'ra>) -> bool {


Could this hack be removed since pdf-0.9.1 had fixed this (#149195 (comment))?

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2025

rustbot assigned nnethercote Nov 21, 2025

This comment has been minimized.

Sign in to view

rust-bors Bot added a commit that referenced this pull request Nov 21, 2025

Auto merge of #149195 - petrochenkov:globamberr, r=<try>

446cb60

resolve: Convert `ambiguous_glob_imports` lint into a hard error

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2025

This comment was marked as resolved.

Sign in to view

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 1, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2025

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 1, 2025

petrochenkov mentioned this pull request Dec 1, 2025

resolve: Preserve ambiguous glob reexports in crate metadata #147984

Merged

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 9, 2025

This comment has been minimized.

Sign in to view

traviscross mentioned this pull request Apr 8, 2026

Resolver: Batched Import Resolution #145108

Open

This comment has been minimized.

Sign in to view

petrochenkov mentioned this pull request May 7, 2026

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets #156284

Merged

rustbot mentioned this pull request May 16, 2026

Tracking issue for release notes of #149195: resolve: Partially convert ambiguous_glob_imports lint into a hard error #156648

Open

resolve: Partially convert ambiguous_glob_imports lint into a hard …

241cdda

…error

mu001999 reviewed May 17, 2026

View reviewed changes

Uh oh!

Conversation

petrochenkov commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 21, 2025

Uh oh!

rustbot commented Nov 21, 2025

Uh oh!

petrochenkov commented Nov 21, 2025

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 21, 2025

Uh oh!

petrochenkov commented Nov 22, 2025

Uh oh!

craterbot commented Nov 22, 2025

Uh oh!

This comment was marked as resolved.

craterbot commented Nov 29, 2025

Uh oh!

craterbot commented Dec 1, 2025

Footnotes

Uh oh!

nnethercote commented Dec 1, 2025

Uh oh!

petrochenkov commented Dec 1, 2025

Uh oh!

rustbot commented Dec 1, 2025

Uh oh!

petrochenkov commented Dec 1, 2025

Uh oh!

yaahc commented Dec 9, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Mar 13, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented Mar 13, 2026

Uh oh!

rust-bors Bot commented Mar 13, 2026

Uh oh!

petrochenkov commented Mar 13, 2026

Uh oh!

craterbot commented Mar 13, 2026

Uh oh!

craterbot commented Mar 13, 2026

Uh oh!

craterbot commented Mar 13, 2026

Footnotes

Uh oh!

This comment has been minimized.

petrochenkov commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change description for lang team

Uh oh!

yaahc commented Mar 25, 2026

Uh oh!

traviscross commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-rfcbot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshtriplett commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

petrochenkov commented Apr 29, 2026

Uh oh!

tmandry commented May 6, 2026

Uh oh!

rust-rfcbot commented May 6, 2026

Uh oh!

joshtriplett commented May 6, 2026

Uh oh!

petrochenkov commented May 7, 2026

Uh oh!

rust-rfcbot commented May 16, 2026

petrochenkov commented Nov 21, 2025 •

edited

Loading

petrochenkov commented Mar 19, 2026 •

edited

Loading

traviscross commented Apr 8, 2026 •

edited

Loading

rust-rfcbot commented Apr 8, 2026 •

edited

Loading

joshtriplett commented Apr 8, 2026 •

edited

Loading

mu001999 left a comment •

edited by rustbot

Loading