Skip to content

CLDSRV-926: skip async/await diff check when PR has skip-async-migration label#6189

Open
DarkIsDude wants to merge 2 commits into
development/9.3from
w/9.3/feature/CLDSRV-926/skip-async-check-on-pr-label
Open

CLDSRV-926: skip async/await diff check when PR has skip-async-migration label#6189
DarkIsDude wants to merge 2 commits into
development/9.3from
w/9.3/feature/CLDSRV-926/skip-async-check-on-pr-label

Conversation

@DarkIsDude

Copy link
Copy Markdown
Contributor

Summary

  • Adds pull-requests: read permission to the tests.yaml workflow
  • The "Check async/await compliance in diff" step now checks whether the current branch's open PR carries the skip-async-migration label before running check-diff-async
  • If the label is present the step exits cleanly; otherwise the check runs as before

Behaviour

Scenario Result
PR has skip-async-migration label Step skips, exits 0
PR does not have the label check-diff-async runs normally
No open PR (direct push / workflow_dispatch) check-diff-async runs normally

Pre-requisite

The skip-async-migration label must be created in the repository settings before use.

Closes CLDSRV-926

@DarkIsDude DarkIsDude self-assigned this Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
8483 4 8479 0
View the top 2 failed test(s) by shortest run time
"before each" hook for "should retrieve a part copied from an MPU"::GET object With v4 signature With PartNumber field uploadPartCopy "before each" hook for "should retrieve a part copied from an MPU"
Stack Traces | 5.49s run time
Connection timed out after 5000 ms
"before each" hook for "should retrieve a part put after part copied from MPU"::GET object With v4 signature With PartNumber field uploadPartCopy "before each" hook for "should retrieve a part put after part copied from MPU"
Stack Traces | 5.53s run time
Connection timed out after 5000 ms
View the full list of 2 ❄️ flaky test(s)
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 5 times)

Stack Traces | 0.023s run time
We encountered an internal error. Please try again.
"before each" hook for "should retrieve a part copied from an MPU"::GET object With default signature With PartNumber field uploadPartCopy "before each" hook for "should retrieve a part copied from an MPU"

Flake rate in main: 100.00% (Passed 0 times, Failed 9 times)

Stack Traces | 5.53s run time
Connection timed out after 5000 ms

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Comment thread .github/workflows/tests.yaml
@claude

This comment was marked as resolved.

@claude

claude Bot commented Jun 16, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@DarkIsDude DarkIsDude marked this pull request as ready for review June 16, 2026 14:22
@DarkIsDude DarkIsDude requested review from a team, delthas and maeldonn June 16, 2026 14:22
Comment on lines +111 to +113
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH_NAME: ${{ github.ref_name }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to list PRs from bash script?
can't we use an if condition, something like:

Suggested change
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH_NAME: ${{ github.ref_name }}
`if: ${{ contains(github.event.pull_request.labels.*.name, 'skip-async-migration' }}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esp. check would fail if PR is not opened...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking on it: maybe both these refactoring checks should ONLY be performed on PR event (not on push), so they check only the code we modify and don't force people to add reformatting/... in waterflow branches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants