Skip to content

CLDSRV-926: skip async/await diff check when PR has skip-async-migration label #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkIsDude wants to merge 2 commits into
base: development/9.3
Choose a base branch
from
+11 −1
Open

CLDSRV-926: skip async/await diff check when PR has skip-async-migration label #6189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd7a15
✅ skip async/await diff check when PR has skip-async-migration label
DarkIsDude Jun 15, 2026
523f334
🔒 harden script injection in async/await check step
DarkIsDude Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ env:
permissions:
contents: read
packages: write
pull-requests: read

jobs:
lint:
Expand Down Expand Up @@ -107,7 +108,16 @@ jobs:
- name: Lint Yaml
run: yamllint -c yamllint.yml $(git ls-files "*.yml")
- name: Check async/await compliance in diff
run: yarn run check-diff-async
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH_NAME: ${{ github.ref_name }}
Comment on lines +111 to +113

@francoisferrand francoisferrand Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to list PRs from bash script?
can't we use an if condition, something like:

Suggested change
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH_NAME: ${{ github.ref_name }}
`if: ${{ contains(github.event.pull_request.labels.*.name, 'skip-async-migration' }}`

@francoisferrand francoisferrand Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esp. check would fail if PR is not opened...

@francoisferrand francoisferrand Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking on it: maybe both these refactoring checks should ONLY be performed on PR event (not on push), so they check only the code we modify and don't force people to add reformatting/... in waterflow branches?

run: |
if gh pr list --head "$BRANCH_NAME" --state open --json labels \
--jq '.[].labels[].name' 2>/dev/null | grep -qx 'skip-async-migration'; then
echo "Skipping async/await check: 'skip-async-migration' label found"
else
yarn run check-diff-async
fi
Comment thread
DarkIsDude marked this conversation as resolved.

async-migration-report:
runs-on: ubuntu-24.04
Expand Down
Loading