Add a config_file argument to the gateway launchfile to allow using an external config file.#408
Merged
bburda merged 3 commits intoJun 6, 2026
Conversation
…n external config file.
bburda
reviewed
Jun 3, 2026
Collaborator
bburda
left a comment
There was a problem hiding this comment.
Nice, backward-compatible addition - defaulting config_file to the packaged config keeps existing launches unchanged.
One thing before merge: docs. config_file is a new public launch argument and isn't documented - the README has a launch-args table for gateway_https.launch.py, and gateway.launch.py should get an equivalent entry. Please also call out the replace semantics there (see inline).
Out of scope, your call: gateway_https.launch.py uses the same parameters=[default_config, {...}] pattern and could take the same config_file arg for parity.
…override parameters present in the and keep the other value to their default value. - Updated documentation of the ros2 gateway configuration.
bburda
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Pull Request
Summary
Added an optional config_file argument to the ros2_mekdit_gateway to be able to set the gateway parameters from outside the ros2_mekdit_gateway. This feature is proposed for large projects where the gateway config lives in another bringup package and needs to be feed to the gateway.
Issue
Link the related issue (required):
No issues, its new feature.
Type
Testing
How was this tested / how should reviewers verify it?:
I launched the gateway with and without the new config_file orverride:
and
In my
gateway_params.yamlfrom mybringup_package, I enable the CORS parameters. So when I launched the gateway without the config file, therosoutlog showed that CORS was disabled, and when I launched with the config_file, the log said CORS was enabled.Also, I did all the test in https://github.com/selfpatch/ros2_medkit/blob/main/CONTRIBUTING.md with success.
Since no code had to be build, there wasn't that much build test to do.
Checklist