feat: affiliate fee split model (partnerBps + shapeshiftBps)

[kaladinlight]

Description

Introduces the split-fee affiliate model across the stack. affiliateBps is now the total on-chain fee while partnerBps and shapeshiftBps are the configured intent snapshotted at quote time. Swap-service owns the source of truth; web, public-api, swap-widget, and the affiliate dashboard are updated to consume and forward the three values consistently.

Pairs with: companion microservices PR on feat/swap-bps-and-partner-fields (separate repo).

Issue (if applicable)

closes #

Risk

Medium. Touches the affiliate fee plumbing end-to-end and the public-api request/response surface. No on-chain transaction changes. Verified manually against swap-service local; existing test suites pass after fixture updates.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

All swappers indirectly through affiliate-fee plumbing — no protocol-specific changes. THORChain getL1RateOrQuote switches .toString() → .toFixed(0) on integer base-unit strings (correctness, not behavioral).

Breaking API changes — call out for integrators

• POST /v1/swap/quote: sendAddress is now required (was optional).
• POST /v1/swap/quote and /v1/swap/rates: allowMultiHop request param removed; always single-hop.
• GET /v1/swap/status response: affiliateAddress removed; partnerAddress added.
• All affiliate config endpoints now return partnerBps + shapeshiftBps (was bps).

Testing

Engineering

• pnpm run lint --fix && pnpm run type-check (both packages)
• pnpm test in packages/public-api (includes new calculatePartnerFeeAmountUsd regression tests for the Math.min(partnerBps/affiliateBps, 1) cap and the fee-exempt branch)
• Manual: hit a partner URL → confirm partner_bps, shapeshift_bps, partner_code written to localStorage with the partner's share (not the legacy total + 10). Then trade and inspect the POST /swaps payload — should send all three bps as numbers plus partnerAddress / partnerCode.
• Existing users on the previous storage schema: the module-load migration in useAffiliateTracking clears pre-v2 entries once and sets a version marker; returning users see "no partner" until they re-hit a partner URL.

Operations

No infra changes. Deploy after the companion swap-service PR lands so the /v1/partner/:code and affiliate config responses include shapeshiftBps.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Affiliate dashboard now displays partner basis points separately from shapeshift fees
  • Added partner address tracking to affiliate information

• Updates

  • Partner code label simplified to "Code" in settings
  • Updated messaging on partner code earnings

• Refactor

  • Restructured fee breakdown to distinguish partner fees from shapeshift fees across dashboard and API responses

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR refactors the affiliate fee structure across the entire ShapeShift stack, splitting the single bps field into separate partnerBps and shapeshiftBps components. It also migrates client-side partner tracking from code-based to address-based resolution. The changes affect API contracts, middleware, quote/rate handlers, affiliate-specific routes, and client-side fee integration.

Changes

Affiliate Fee Structure Refactoring

Layer / File(s)	Summary
Affiliate data model and BpsFields schema packages/public-api/src/types.ts	Introduces BpsFields constant with Zod schemas for affiliateBps, optional partnerBps, and required shapeshiftBps; updates AffiliateInfo type to include partnerAddress?, partnerCode?, partnerBps?, and required shapeshiftBps.
Public API contract schemas packages/public-api/src/routes/affiliate/types.ts, packages/public-api/src/routes/quote/types.ts, packages/public-api/src/routes/rates/types.ts, packages/public-api/src/routes/status/types.ts	Updates AffiliateConfigResponseSchema to use partnerBps instead of bps; makes affiliateBps non-nullable in swap service schemas; adds partnerBps to swap service schema; refactors quote/rates/status response schemas to use BpsFields spread and removes affiliateAddress fields; removes allowMultiHop from request schemas.
Quote storage and partner resolution packages/public-api/src/lib/quoteStore.ts, packages/public-api/src/lib/quoteStore.test.ts, packages/public-api/src/middleware/auth.ts	Updates StoredQuote type to include partnerAddress?, partnerBps?, and required shapeshiftBps; removes affiliateAddress, sellChainId, and stepChainIds; refactors resolvePartnerCodeFromService to parse and return partnerAddress, partnerBps, and shapeshiftBps via Zod schema; computes affiliateBps as the sum of partnerBps and shapeshiftBps.
Quote endpoint: allowMultiHop removal and baseQuote refactoring packages/public-api/src/routes/quote/getQuote.ts	Hardcodes allowMultiHop: false instead of accepting from request; updates EVM chain detection to use CHAIN_NAMESPACE.Evm; introduces shared baseQuote object and refactors quote storage to include partnerBps/shapeshiftBps and remove affiliateAddress/sellChainId/stepChainIds; makes approval generation unconditional.
Rates endpoint: allowMultiHop and bps field updates packages/public-api/src/routes/rates/getRates.ts, packages/public-api/src/routes/rates/types.ts	Hardcodes allowMultiHop: false; derives buy amount from last step instead of first step; updates bps field mapping to use partnerBps/shapeshiftBps; removes affiliateAddress from response.
Affiliate-specific routes: partner fee and swaps packages/public-api/src/routes/affiliate/calculatePartnerFeeAmountUsd.ts, packages/public-api/src/routes/affiliate/calculatePartnerFeeAmountUsd.test.ts, packages/public-api/src/routes/affiliate/getAffiliateSwaps.ts	Refactors partner fee calculation to immediately return null when partnerBps or affiliateBps is falsy; implements fee capping when partnerBps >= affiliateBps; derives partnerBps directly from swap data instead of computing from affiliateBps and shapeshiftBps; adds test cases for fee-exempt and capping scenarios.
Status endpoint: partner fields and registration payload packages/public-api/src/routes/status/getSwapStatus.ts, packages/public-api/src/routes/status/utils.ts	Updates status response to include partnerAddress, partnerBps, and shapeshiftBps from stored quote; refactors registration payload builder to send partner data with numeric conversions instead of parsed affiliate bps.
Client affiliate tracking: address-based resolution and storage src/hooks/useAffiliateTracking/useAffiliateTracking.ts, src/hooks/useAffiliateTracking/index.ts	Major refactor from code-based to address-based partner resolution fetching from SWAP_SERVICE_BASE_URL; introduces localStorage versioning for migration; adds readStoredAffiliateBps() that sums partnerBps and shapeshiftBps with fallback; updates state to use partnerAddress instead of affiliate address; exports new reader functions for partner address/BPS/shapeshift BPS.
Trade execution and fee calculation integration src/lib/tradeExecution.ts, src/lib/fees/utils.ts	Updates trade creation payload to send partnerAddress, partnerBps, and shapeshiftBps instead of partner code; refactors getAffiliateBps() to use readStoredAffiliateBps() helper for total affiliate fee computation.
Widget and dashboard types: partnerBps and shapeshiftBps packages/swap-widget/src/types/index.ts, packages/affiliate-dashboard/src/hooks/useAffiliateConfig.ts, packages/affiliate-dashboard/src/hooks/useAffiliateSwaps.ts, packages/affiliate-dashboard/src/components/ConfigBar.tsx, packages/affiliate-dashboard/src/components/settings/ConfigSummaryCard.tsx, packages/affiliate-dashboard/src/components/settings/SettingsTab.tsx	Updates TradeQuote, TradeRate, and QuoteResponse types to include optional partnerBps and required shapeshiftBps; removes affiliateAddress field; updates affiliate dashboard config schema to expect partnerBps and shapeshiftBps; updates UI components to display config.partnerBps and changes "Partner Code" label to "Code".
Test fixtures and number formatting packages/swap-widget/src/machines/__tests__/swapMachine.test.ts, packages/swap-widget/src/machines/__tests__/types.test.ts, packages/swapper/src/thorchain-utils/getL1RateOrQuote.ts	Updates swap machine test fixtures to include shapeshiftBps field; refactors quote fixtures to use as unknown as QuoteResponse casting; changes thorchain fee formatting to use toFixed(0) for consistent integer string output.
Dashboard description update packages/affiliate-dashboard/src/components/settings/RegisterCard.tsx	Updates settings card description text to clarify fee earnings message for partner code usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

This PR involves substantial changes across the entire stack with multiple interconnected layers. The refactoring affects data models, API contracts, middleware logic, multiple route handlers, client-side storage and resolution, and test fixtures. While most changes are consistent patterns (field renames and structure changes), the complexity arises from the breadth of affected files, the logic changes in fee calculation and partner resolution, and the need to verify data flow across all layers.

🐰 A rabbit hops through fields where partners prance,
Where bps now splits in a graceful dance,
Address-based tracking, fees so clear,
Partner and Shapeshift together appear! 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: introducing a split-fee affiliate model using partnerBps and shapeshiftBps instead of a single bps field, which is the primary architectural change across the entire changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/affiliate-fee-split

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/public-api/src/routes/status/utils.ts`:
- Around line 25-27: The BPS fields currently convert values with Number(...)
which turns invalid/missing inputs into NaN (serialized as null) and the
partnerBps ternary drops numeric 0; update the mapping for partnerBps,
affiliateBps, and shapeshiftBps to validate and preserve zero by only converting
when storedQuote.<field> is not null/undefined and is a valid finite number
string/number (e.g., use Number.isFinite(Number(val)) or a small helper like
toNumberOrUndefined(val) that returns undefined for null/undefined/invalid and
returns 0 for "0"), and otherwise set the property to undefined so JSON won’t
contain null/NaN values. Ensure you change the three references partnerBps,
affiliateBps, and shapeshiftBps in utils.ts accordingly.

In `@src/hooks/useAffiliateTracking/useAffiliateTracking.ts`:
- Around line 72-85: resolvePartnerCode currently parses remote JSON and returns
it without checking shape; add a runtime guard that verifies the parsed object
matches the PartnerData contract (presence and types of required fields) before
returning or letting it be cached in localStorage. Modify resolvePartnerCode to
validate the decoded JSON (e.g., check required keys and primitive types on the
object returned by await response.json()), return null if validation fails, and
ensure any place that stores partner info to localStorage only writes when the
value is a valid PartnerData. Use the PartnerData type and the
resolvePartnerCode function name to locate where to add the guard.
- Around line 138-143: readStoredAffiliateBps can return "NaN" if stored strings
are non-numeric; fix by parsing and validating both stored values (use
readStored(PARTNER_BPS_KEY) and readStored(SHAPESHIFT_BPS_KEY)), convert each to
Number, and check with Number.isFinite (or !Number.isNaN) — if either parsed
value is invalid, return DEFAULT_FEE_BPS; otherwise return String(parsedPartner
+ parsedShapeshift). Ensure you reference readStoredAffiliateBps,
PARTNER_BPS_KEY, SHAPESHIFT_BPS_KEY, DEFAULT_FEE_BPS, and readStored when making
the change.

In `@src/lib/tradeExecution.ts`:
- Around line 223-240: Validate numeric fee fields before sending the POST to
/swaps: when building the payload in the axios.post call, parse and guard
partnerBps (from readStoredPartnerBps()), shapeshiftBps (from
readStoredShapeshiftBps()) and any use of affiliateBps so they are finite
numbers (e.g., Number(...) and Number.isFinite check); if a parsed value is NaN
or not finite, omit the field (use undefined) or fallback to a safe default (for
shapeshiftBps fallback to affiliateBps only if affiliateBps is valid). Update
the payload construction around partnerBps and shapeshiftBps in
tradeExecution.ts so invalid localStorage values do not result in NaN being
posted.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb47ab28-1374-42ad-a02e-5d66b26af6bc

📥 Commits

Reviewing files that changed from the base of the PR and between 17460d2 and 99c7e4f.

📒 Files selected for processing (29)

• packages/affiliate-dashboard/src/components/ConfigBar.tsx
• packages/affiliate-dashboard/src/components/settings/ConfigSummaryCard.tsx
• packages/affiliate-dashboard/src/components/settings/RegisterCard.tsx
• packages/affiliate-dashboard/src/components/settings/SettingsTab.tsx
• packages/affiliate-dashboard/src/hooks/useAffiliateConfig.ts
• packages/affiliate-dashboard/src/hooks/useAffiliateSwaps.ts
• packages/public-api/src/lib/quoteStore.test.ts
• packages/public-api/src/lib/quoteStore.ts
• packages/public-api/src/middleware/auth.ts
• packages/public-api/src/routes/affiliate/calculatePartnerFeeAmountUsd.test.ts
• packages/public-api/src/routes/affiliate/calculatePartnerFeeAmountUsd.ts
• packages/public-api/src/routes/affiliate/getAffiliateSwaps.ts
• packages/public-api/src/routes/affiliate/types.ts
• packages/public-api/src/routes/quote/getQuote.ts
• packages/public-api/src/routes/quote/types.ts
• packages/public-api/src/routes/rates/getRates.ts
• packages/public-api/src/routes/rates/types.ts
• packages/public-api/src/routes/status/getSwapStatus.ts
• packages/public-api/src/routes/status/types.ts
• packages/public-api/src/routes/status/utils.ts
• packages/public-api/src/types.ts
• packages/swap-widget/src/machines/__tests__/swapMachine.test.ts
• packages/swap-widget/src/machines/__tests__/types.test.ts
• packages/swap-widget/src/types/index.ts
• packages/swapper/src/thorchain-utils/getL1RateOrQuote.ts
• src/hooks/useAffiliateTracking/index.ts
• src/hooks/useAffiliateTracking/useAffiliateTracking.ts
• src/lib/fees/utils.ts
• src/lib/tradeExecution.ts