fix(branding): refresh Google branding - #6786
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
Google Vault OAuth metadata now uses the dedicated Auth UX tweaks: the Google chip on login/signup uses Reviewed by Cursor Bugbot for commit 1e875be. Configure here. |
Greptile SummaryThe PR refreshes Google branding while preserving the shared icon API.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the browser-fragile SVG primitives reported previously have been removed in favor of a plain raster-backed SVG image.
|
| Filename | Overview |
|---|---|
| apps/sim/components/icons.tsx | Replaces the legacy vector Google mark with the official PNG embedded in a plain SVG wrapper; no blocking issue remains from the prior rendering thread. |
| apps/docs/components/icons.tsx | Keeps the generated docs icon projection synchronized with the application icon. |
| apps/sim/app/(auth)/components/social-login-buttons.tsx | Updates the Google CTA wording and renders the refreshed icon through the Chip adornment API. |
| apps/sim/app/(landing)/components/auth-modal/auth-modal.tsx | Aligns the landing authentication modal’s Google icon size with the updated branding. |
| apps/sim/lib/oauth/oauth.ts | Correctly assigns the dedicated Google Vault icon while preserving the corporate Google base-provider mark. |
| apps/sim/lib/oauth/oauth.test.ts | Verifies the Google Vault and base-provider icon mappings. |
Reviews (2): Last reviewed commit: "refactor(branding): trim Google icon tes..." | Re-trigger Greptile
8328c9b to
7ee278c
Compare
7ee278c to
705ecd7
Compare
|
@BillLeoutsakosvl346 should we be using svgs like we do now instead of pointing it at a uri? |
I did it like that initially, but there was a problem with foreignObject which has some problem to do with WebKit, that's why I ended up with that approach, but lmk if you want to revert it and if it looks ok disregard all the errors. |
|
@icecrasher321 bugbot also pointed this out in my first attempts to make this |
Drop the GoogleIcon and SocialLoginButtons snapshot tests: they pinned exact attribute strings, the asset byte length, and the absence of markup the component never contained, so they broke on any legitimate tweak without catching real regressions. Correct the wrapper's viewBox to 0 0 200 204 so it matches the artwork, which bleeds to all four edges. The previous 204-wide box pinned four units of dead space to the right via xMinYMin, offsetting the mark within its box. Rewrite the TSDoc: it described avoiding a WebKit foreignObject gradient bug, but this file never used foreignObject and already ships 106 linearGradient definitions. Document the real reason instead - Google publishes the current G only as a raster. Align the auth button icon on shrink-0 with its sibling callsite.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1e875be. Configure here.



Summary
g-logo.pngis embedded verbatim (200x204 RGBA, SHA-256d1ce9c2af0b10a7333abc99bc706f9a6a199e5b65bf3e3009624f076b8638e6a) inside a plain SVG wrapper that preserves the sharedGoogleIcon(props: SVGProps<SVGSVGElement>)API and every callsite.GoogleVaultIconproduct icon while retaining the corporate Google base-provider icon.Type of Change
Testing
bun run type-checkbun run lint:checkbun run check:icon-pathsbun run check:bare-iconsbun run docs:check— generated docs in sync,apps/docs/components/icons.tsxbyte-identical to the sim copylib/oauth/oauth.test.ts— 42 passed, covering the Vault icon wiringReviewer focus:
viewBoxis0 0 200 204, matching the artwork, which bleeds to all four edges.data:is permitted byimg-srcinlib/core/security/csp.ts, so the embedded asset is not CSP-blocked.Known trade-off: the raster costs ~33.8 KB gzipped versus ~0.7 KB for the previous vector paths, and
GoogleIconreaches the auth, landing, canvas/block-registry, BYOK-settings, and integrations bundles. Accepted here to keep the mark pixel-exact to Google's published asset.Checklist