Skip to content

fix(branding): refresh Google branding - #6786

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/google-branding-refresh
Aug 19, 2026
Merged

fix(branding): refresh Google branding#6786
waleedlatif1 merged 2 commits into
stagingfrom
fix/google-branding-refresh

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the legacy flat 4-color Google "G" with Google's current mark. Google publishes it only as a raster, so the official g-logo.png is embedded verbatim (200x204 RGBA, SHA-256 d1ce9c2af0b10a7333abc99bc706f9a6a199e5b65bf3e3009624f076b8638e6a) inside a plain SVG wrapper that preserves the shared GoogleIcon(props: SVGProps<SVGSVGElement>) API and every callsite.
  • Correct Google Vault OAuth surfaces to use the existing dedicated GoogleVaultIcon product icon while retaining the corporate Google base-provider icon.
  • Align Google authentication CTAs on login, signup, and the landing auth modal with current wording and 20px icon sizing.
  • Regenerate the docs icon projection.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other

Testing

  • bun run type-check
  • bun run lint:check
  • bun run check:icon-paths
  • bun run check:bare-icons
  • bun run docs:check — generated docs in sync, apps/docs/components/icons.tsx byte-identical to the sim copy
  • lib/oauth/oauth.test.ts — 42 passed, covering the Vault icon wiring

Reviewer focus:

  • The embedded asset is byte-identical to https://developers.google.com/static/identity/images/g-logo.png (verified by hash against a live fetch).
  • The SVG wrapper's viewBox is 0 0 200 204, matching the artwork, which bleeds to all four edges.
  • data: is permitted by img-src in lib/core/security/csp.ts, so the embedded asset is not CSP-blocked.
  • Product-specific Google marks are unchanged.

Known trade-off: the raster costs ~33.8 KB gzipped versus ~0.7 KB for the previous vector paths, and GoogleIcon reaches the auth, landing, canvas/block-registry, BYOK-settings, and integrations bundles. Accepted here to keep the mark pixel-exact to Google's published asset.

Checklist

  • Code follows project style guidelines
  • Self-reviewed the changes
  • No new warnings introduced
  • I confirm that I have read and agree to the Contributor License Agreement

@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 19, 2026 8:13pm

Request Review

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Visual and copy changes to icons and auth CTAs only; no auth logic, security, or data-handling changes. Trade-off is a larger gzipped asset for GoogleIcon wherever it is bundled.

Overview
Updates Google branding across auth and OAuth surfaces to match Google's current identity guidelines.

GoogleIcon no longer uses the legacy flat four-color vector paths. It now wraps Google's official raster G mark (embedded as a base64 PNG inside an SVG with viewBox 0 0 200 204), keeping the same SVGProps<SVGSVGElement> API. The same change is mirrored in apps/docs/components/icons.tsx.

Google Vault OAuth metadata now uses the dedicated GoogleVaultIcon for the service icon while GoogleIcon remains the corporate baseProviderIcon, with a unit test asserting that wiring.

Auth UX tweaks: the Google chip on login/signup uses leftAdornment with a 20px icon and the label "Continue with Google"; the landing auth modal matches the 20px icon size.

Reviewed by Cursor Bugbot for commit 1e875be. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR refreshes Google branding while preserving the shared icon API.

  • Embeds Google’s current raster mark in the existing SVG wrapper and mirrors it into the docs projection.
  • Uses the dedicated Google Vault product icon while retaining Google as its base-provider icon.
  • Updates authentication CTA wording and icon sizing.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the browser-fragile SVG primitives reported previously have been removed in favor of a plain raster-backed SVG image.

Important Files Changed

Filename Overview
apps/sim/components/icons.tsx Replaces the legacy vector Google mark with the official PNG embedded in a plain SVG wrapper; no blocking issue remains from the prior rendering thread.
apps/docs/components/icons.tsx Keeps the generated docs icon projection synchronized with the application icon.
apps/sim/app/(auth)/components/social-login-buttons.tsx Updates the Google CTA wording and renders the refreshed icon through the Chip adornment API.
apps/sim/app/(landing)/components/auth-modal/auth-modal.tsx Aligns the landing authentication modal’s Google icon size with the updated branding.
apps/sim/lib/oauth/oauth.ts Correctly assigns the dedicated Google Vault icon while preserving the corporate Google base-provider mark.
apps/sim/lib/oauth/oauth.test.ts Verifies the Google Vault and base-provider icon mappings.

Reviews (2): Last reviewed commit: "refactor(branding): trim Google icon tes..." | Re-trigger Greptile

Comment thread apps/sim/components/icons.test.tsx Outdated
Comment thread apps/sim/components/icons.tsx Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

How it looks now:

demo1 demo2 demo3

@icecrasher321

Copy link
Copy Markdown
Collaborator

@BillLeoutsakosvl346 should we be using svgs like we do now instead of pointing it at a uri?

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@BillLeoutsakosvl346 should we be using svgs like we do now instead of pointing it at a uri?

I did it like that initially, but there was a problem with foreignObject which has some problem to do with WebKit, that's why I ended up with that approach, but lmk if you want to revert it and if it looks ok disregard all the errors.

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

#6786 (comment)

@icecrasher321 bugbot also pointed this out in my first attempts to make this

Drop the GoogleIcon and SocialLoginButtons snapshot tests: they pinned exact
attribute strings, the asset byte length, and the absence of markup the
component never contained, so they broke on any legitimate tweak without
catching real regressions.

Correct the wrapper's viewBox to 0 0 200 204 so it matches the artwork, which
bleeds to all four edges. The previous 204-wide box pinned four units of dead
space to the right via xMinYMin, offsetting the mark within its box.

Rewrite the TSDoc: it described avoiding a WebKit foreignObject gradient bug,
but this file never used foreignObject and already ships 106 linearGradient
definitions. Document the real reason instead - Google publishes the current G
only as a raster.

Align the auth button icon on shrink-0 with its sibling callsite.
@waleedlatif1

Copy link
Copy Markdown
Collaborator

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1e875be. Configure here.

@waleedlatif1
waleedlatif1 merged commit 5d6268d into staging Aug 19, 2026
31 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/google-branding-refresh branch August 19, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants