Skip to content

fix(branding): refresh Google branding #6786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Aug 19, 2026
Merged

fix(branding): refresh Google branding #6786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
705ecd7
fix(branding): refresh Google logo
Aug 17, 2026
1e875be
refactor(branding): trim Google icon tests and correct the SVG wrapper
waleedlatif1 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions apps/docs/components/icons.tsx
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions apps/sim/app/(auth)/components/social-login-buttons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ export function SocialLoginButtons({
const googleButton = (
<Chip
fullWidth
leftIcon={GoogleIcon}
leftAdornment={<GoogleIcon className='size-[20px] shrink-0' />}
className={cn(AUTH_BUTTON_CLASS, 'border border-[var(--border-1)]')}
disabled={!googleAvailable || isGoogleLoading}
onClick={signInWithGoogle}
>
{isGoogleLoading ? 'Connecting…' : 'Google'}
{isGoogleLoading ? 'Connecting…' : 'Continue with Google'}
</Chip>
)

Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/(landing)/components/auth-modal/auth-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export function AuthModal({ children, defaultView = 'login', source }: AuthModal
disabled={!!socialLoading}
className={SOCIAL_BTN}
>
<GoogleIcon className='absolute left-4 size-[18px] shrink-0' />
<GoogleIcon className='absolute left-4 size-[20px] shrink-0' />
<span>
{socialLoading === 'google' ? 'Connecting...' : 'Continue with Google'}
</span>
Expand Down
39 changes: 22 additions & 17 deletions apps/sim/components/icons.tsx
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 11 additions & 1 deletion apps/sim/lib/oauth/oauth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ beforeAll(() => {

afterAll(resetEnvMock)

import { GoogleIcon, GoogleVaultIcon } from '@/components/icons'
import { DEFAULT_MAX_ERROR_BODY_BYTES } from '@/lib/core/utils/stream-limits'
import { refreshOAuthToken } from '@/lib/oauth'
import { OAUTH_PROVIDERS, refreshOAuthToken } from '@/lib/oauth'
import { REDDIT_USER_AGENT } from '@/tools/reddit/constants'

/**
Expand All @@ -90,6 +91,15 @@ function withMockFetch<T>(mockFetch: ReturnType<typeof vi.fn>, fn: () => Promise
})
}

describe('OAuth Provider Branding', () => {
it('should use the Google Vault product icon and Google base-provider icon', () => {
const googleVault = OAUTH_PROVIDERS.google.services['google-vault']

expect(googleVault.icon).toBe(GoogleVaultIcon)
expect(googleVault.baseProviderIcon).toBe(GoogleIcon)
})
})

describe('OAuth Token Refresh', () => {
describe('Basic Auth Providers', () => {
const basicAuthProviders = [
Expand Down
3 changes: 2 additions & 1 deletion apps/sim/lib/oauth/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
GoogleMeetIcon,
GoogleSheetsIcon,
GoogleTasksIcon,
GoogleVaultIcon,
HubspotIcon,
InstagramIcon,
JiraIcon,
Expand Down Expand Up @@ -255,7 +256,7 @@ export const OAUTH_PROVIDERS: Record<string, OAuthProviderConfig> = {
name: 'Google Vault',
description: 'Search, export, and manage matters/holds via Google Vault.',
providerId: 'google-vault',
icon: GoogleIcon,
icon: GoogleVaultIcon,
baseProviderIcon: GoogleIcon,
scopes: [
'https://www.googleapis.com/auth/userinfo.email',
Expand Down
Loading