Skip to content

Add UniFi#3949

Closed
wolffcatskyy wants to merge 3 commits intosindresorhus:mainfrom
wolffcatskyy:add-unifi
Closed

Add UniFi#3949
wolffcatskyy wants to merge 3 commits intosindresorhus:mainfrom
wolffcatskyy:add-unifi

Conversation

@wolffcatskyy
Copy link
Copy Markdown

https://github.com/wolffcatskyy/awesome-unifi#readme

UniFi is a line of enterprise networking equipment by Ubiquiti, including wireless access points, switches, routers, security gateways, cameras, and access control systems. The list covers API libraries, monitoring tools, home automation integrations, and community utilities.

By submitting this pull request I confirm I've read and complied with the below requirements

Requirements for your pull request

  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests. I reviewed Add awesome-infrastructure to Back-End Development section #3945 and Add Code Docs to Miscellaneous #3942 with detailed feedback.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List. It should not contain the word Awesome.
  • Your entry here should include a short description of the project/theme of the list. It should not describe the list itself.
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
  • No blockchain-related lists.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days. (Note: The repo was created on Feb 16, 2026. I am submitting now for tracking purposes and will wait for the 30-day mark before expecting a merge. Please keep open or I can resubmit after March 18, 2026.)
  • Run awesome-lint on your list and fix the reported issues.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme.
  • It's the result of hard work and the best I could possibly produce.
  • The repo name of your list should be in lowercase slug format: awesome-unifi.
  • The heading title of your list should be in title case format: # Awesome UniFi.
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics.
  • Not a duplicate. I searched for existing submissions.
  • Only has awesome items. Curated 100+ high-quality resources.
  • Does not contain items that are unmaintained, archived, deprecated, or missing docs.
  • Includes a project logo/illustration.
  • Entries have a description.
  • Includes the Awesome badge.
  • Has a Table of Contents section named Contents.
  • Has an appropriate license: CC0-1.0.
  • Has contribution guidelines (CONTRIBUTING.md).
  • Has consistent formatting and proper spelling/grammar.
  • Does not use hard-wrapping.
  • Does not include a CI badge.
  • Does not include an "Inspired by" link.

unicorn

@be-next
Copy link
Copy Markdown

be-next commented Feb 18, 2026

Hey @wolffcatskyy, the UniFi ecosystem definitely deserves a dedicated awesome list ! I went through the PR and the repo carefully and found a few things that need attention.

Blocker:

  • 30-day rule. The repo was created on Feb 16 and the PR was opened the same day. I'd suggest posting there and reopening the PR once the 30-day mark is reached.

Unmaintained/archived entry:

  • calmh/unifi-api is marked [UNMAINTAINED] in its own GitHub description and the repo is archived. You also describe it as "(unmaintained)" in your list. The guidelines explicitly say: "Does not contain items that are unmaintained, has archived repo." This entry must be removed.

Curation quality:

  • WhiskeyTang0F0xtr0t/unifi is described as "Random stuff for unifi devices." That's not what "awesome" curation looks like.
  • Log4jUnifi is an RCE exploit for CVE-2021-44228. Including offensive security tooling targeting a specific product vulnerability feels out of scope for a tools/resources list, and the CVE dates from 2021.
  • The "Other Tools" catch-all section is generally discouraged in awesome lists. Try to find specific homes for those items or remove the ones that don't add clear value.

Unicorn verification:

The word "unicorn" should be posted as a separate comment on the PR, not embedded in the PR body.

The main issues are procedural (timing) and a few curation choices that need tightening. Worth cleaning up and resubmitting at the 30-day mark.

@be-next be-next mentioned this pull request Feb 18, 2026
21 tasks
@wolffcatskyy
Copy link
Copy Markdown
Author

Thanks @be-next — really thorough review, appreciate it.

You're right on all counts:

  • 30-day rule: Will close this and reopen after March 18.
  • calmh/unifi-api: Removing — archived repo shouldn't be listed.
  • WhiskeyTang0F0xtr0t/unifi: Removing — doesn't meet curation bar.
  • Log4jUnifi: Removing — offensive tooling for a 2021 CVE doesn't belong.
  • "Other Tools" section: Will redistribute the strong entries into specific sections and drop the weak ones.
  • Unicorn: Posting separately below.

Will clean up the repo and resubmit at the 30-day mark. Thanks again for the detailed feedback.

@wolffcatskyy
Copy link
Copy Markdown
Author

unicorn

@erkcet
Copy link
Copy Markdown

erkcet commented Feb 22, 2026

Reviewed the list at wolffcatskyy/awesome-unifi. Feedback:

Overall impression
Well-organized list with solid coverage of the UniFi ecosystem. Formatting is consistent and the categorization by language (API libraries) and platform (Home Automation integrations) makes it easy to navigate.

Inconsistent capitalization
There are a few places where "Unifi" appears instead of "UniFi" (the official capitalization). A quick find-and-replace would catch these — it's minor but noticeable in a curated list.

Missing logo/illustration
The awesome-list guidelines say to include a project logo or illustration "whenever possible." The README doesn't have one. Adding the UniFi logo or a network diagram illustration at the top would strengthen the submission. The PR checklist mentions this is required.

30-day requirement
The PR body honestly notes the repo was created Feb 16, 2026, which means the 30-day mark would be around March 18. Appreciate the transparency. The list content itself looks ready — just needs to age.

A few entries to double-check

  • Some entries in the monitoring section reference Docker images that may be wrappers around the same underlying tool (e.g., multiple UniFi Poller variants). Consider consolidating these or noting which is the canonical/actively maintained version.
  • The "Unofficial Ansible Module" entry could benefit from a note about what official gaps it fills, since users will want to know if it's still needed.

Positives

  • CC0 license ✓
  • awesome and awesome-list topics ✓
  • CONTRIBUTING.md present ✓
  • Consistent - [Name](url) - Description. formatting throughout
  • Good breadth: API libs, monitoring, home automation integrations, CLI tools all covered

Solid submission. The main actionable items are adding a logo and fixing the capitalization inconsistencies.

@realadeel
Copy link
Copy Markdown

I reviewed this PR against the awesome list requirements. Here's what I found:

Issue: 30-day requirement not met
The repo was created on February 16, 2026 — only about 7 days ago. The guidelines require: "Has been around for at least 30 days. That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent."

This PR would need to wait until at least mid-March 2026 to satisfy the 30-day rule.

Other observations:

  • The entry format and description look good: - [UniFi](…#readme) - Enterprise wireless and networking equipment by Ubiquiti. — short, descriptive, starts uppercase, ends with period.
  • Category placement (Networking) makes sense.
  • The list itself is well-structured with a clear Contents section, CC0 license, CONTRIBUTING.md, and the awesome badge.
  • Table of Contents has nested sub-items, which is fine (the guideline says "preferably" only one level).
  • Default branch is main, topics include awesome and awesome-list.

@realadeel realadeel mentioned this pull request Feb 23, 2026
16 tasks
@wolffcatskyy
Copy link
Copy Markdown
Author

wolffcatskyy commented Mar 5, 2026

Thanks for the thorough reviews @be-next, @erkcet, and @realadeel! All feedback has been addressed:

  • ✅ Removed archived/unmaintained entries (calmh/unifi-api, WhiskeyTang0F0xtr0t/unifi, Log4jUnifi)
  • ✅ Refactored "Other Tools" catch-all into proper named sections
  • ✅ Fixed ~50 instances of "Unifi" → "UniFi" capitalization in descriptions
  • ✅ Fixed "WiFi"/"Wifi" → "Wi-Fi"
  • ✅ Added logo/illustration at top of README
  • ✅ Added disambiguation notes to UnPoller ecosystem entries (canonical app vs companion libraries/dashboards)
  • ✅ Improved thin descriptions (Ansible Module, UFiber.Configurator, homebridge-guest-wifi)
  • ✅ Added package.json for proper awesome-lint compliance

The 30-day mark lands on March 18 — will close and resubmit then. Thanks again for the feedback, it made the list significantly better.

@wolffcatskyy
Copy link
Copy Markdown
Author

Closing to resubmit per the 30-day policy. Thanks to all reviewers for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants