Skip to content

feat: add enable_helm input#2

Open
hisco wants to merge 2 commits into
mainfrom
enable-helm
Open

feat: add enable_helm input#2
hisco wants to merge 2 commits into
mainfrom
enable-helm

Conversation

@hisco
Copy link
Copy Markdown
Contributor

@hisco hisco commented May 2, 2026

Summary

  • Adds enable_helm input (default true) that passes --enable-helm to kustomize build.
  • When true, fails fast if the helm binary is not on the runner with a clear actionable error.
  • Lets overlays using helmCharts: work out of the box; can be set to false for runners without helm.

Test plan

  • Run on overlay using helmCharts: with helm installed - inspect succeeds.
  • Run with enable_helm: false on a non-helm overlay - behaves as before.
  • Run with enable_helm: true on runner without helm - fails fast with clear error.

Note

Low Risk
Low risk: small, opt-in build flag change plus early tool validation; main impact is CI behavior now requiring helm when enable_helm=true (default).

Overview
Adds a new enable_helm input (default true) that conditionally passes --enable-helm to kustomize build, enabling overlays that use helmCharts:.

When enabled, the action now fails fast during tool checks if the helm binary is not available, and the build step was updated to safely construct/expand the optional flag array. Documentation was updated to describe the new input and its behavior.

Reviewed by Cursor Bugbot for commit 6dc65aa. Bugbot is set up for automated code reviews on this repo. Configure here.

Defaults to true so overlays using helmCharts: work out of the box.
When true, fails fast if the helm binary is not on the runner.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 96f94c9. Configure here.

Comment thread action.yml Outdated
Empty array expansion under set -u errors on bash 3.2 (default on
GitHub macOS runners). Use ${arr[@]+"${arr[@]}"} pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant