feat: add enable_helm input#2
Open
hisco wants to merge 2 commits into
Open
Conversation
Defaults to true so overlays using helmCharts: work out of the box. When true, fails fast if the helm binary is not on the runner.
3 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 96f94c9. Configure here.
Empty array expansion under set -u errors on bash 3.2 (default on
GitHub macOS runners). Use ${arr[@]+"${arr[@]}"} pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
enable_helminput (defaulttrue) that passes--enable-helmtokustomize build.true, fails fast if thehelmbinary is not on the runner with a clear actionable error.helmCharts:work out of the box; can be set tofalsefor runners without helm.Test plan
helmCharts:with helm installed - inspect succeeds.enable_helm: falseon a non-helm overlay - behaves as before.enable_helm: trueon runner without helm - fails fast with clear error.Note
Low Risk
Low risk: small, opt-in build flag change plus early tool validation; main impact is CI behavior now requiring
helmwhenenable_helm=true(default).Overview
Adds a new
enable_helminput (defaulttrue) that conditionally passes--enable-helmtokustomize build, enabling overlays that usehelmCharts:.When enabled, the action now fails fast during tool checks if the
helmbinary is not available, and the build step was updated to safely construct/expand the optional flag array. Documentation was updated to describe the new input and its behavior.Reviewed by Cursor Bugbot for commit 6dc65aa. Bugbot is set up for automated code reviews on this repo. Configure here.