Tighten the permissions of the reusable workflows we export#324
Merged
Conversation
This was referenced May 20, 2026
hslatman
approved these changes
May 20, 2026
azazeal
added a commit
to smallstep/linkedca
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable workflows under
.github/workflows/had a mix of permission issues. Some declared nopermissions:block at all (actionlint.yml,frizbee.yml,goBuild.yml,goLint.yml,goTest.yml,govulncheck.yml,codeql-analysis.yml,zizmor.yml), so callers had to remember what to grant. Others over-granted (docker-buildx-push.ymlhadcontents: writeit never used;triage.ymlgrantedpull-requests: writeandissues: writeto both of its jobs when only one needed anything;dependabot-auto-merge.ymlkeptcontents: writeandpull-requests: writeleft over from before it switched to a PAT). And the implicit "caller must also grant X" contract on the umbrella workflows wasn't documented anywhere.To that end, this PR pins explicit minimum permissions on every reusable workflow, fixes over-grants on
docker-buildx-push.yml,triage.yml, anddependabot-auto-merge.yml, wiressecurity-events: writethroughgoCI.yml's codeql call site, and addsNOTEcomments documenting the caller-permission contract for the two cases where it can't be removed (actionci.yml's zizmor child,goCI.yml's codeql child).The PR also includes a small unrelated
.editorconfigtweak that respects the local tab-width setting.Once this is merged, I'll make a pass over existing callers to amend accordingly.