pkg/beholder: bridge prometheus metrics through otel#2053
Merged
Conversation
✅ API Diff Results -
|
pavel-raykov
previously approved these changes
May 14, 2026
jmank88
force-pushed
the
bridge-prom
branch
2 times, most recently
from
b82f4d0 to
33f3121
Compare
ogtownsend
previously approved these changes
May 19, 2026
pkcll
reviewed
May 20, 2026
pkcll
reviewed
May 20, 2026
pkcll
reviewed
May 20, 2026
pkcll
reviewed
May 20, 2026
jmank88
force-pushed
the
bridge-prom
branch
2 times, most recently
from
e003dc7 to
e4b7a40
Compare
pkcll
previously approved these changes
May 21, 2026
pavel-raykov
previously approved these changes
May 22, 2026
Contributor
Author
|
Removed comment and fixed condition - please re-ack |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 66195c6 | Previous: 969150a | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
792.2 ns/op |
372.6 ns/op |
2.13 |
This comment was automatically generated by workflow using github-action-benchmark.
pavel-raykov
previously approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional support for bridging existing Prometheus metrics into the Beholder/OpenTelemetry metric pipeline (via the OTel Prometheus bridge), controllable through loop server environment configuration.
Changes:
- Introduces
MetricProducersinbeholder.Configand wires producers into the OTelPeriodicReader. - Adds loop env vars to enable the Prometheus bridge and optionally filter bridged metrics by name prefixes.
- Adds a small Prometheus gatherer wrapper (
PrefixGatherer) and updates Beholder config example to a JSON golden file; updates relevant dependencies.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/sqlutil/promutil/promutil.go | New PrefixGatherer to filter Prometheus metric families by prefix. |
| pkg/loop/server.go | Conditionally attaches OTel Prometheus bridge metric producer to Beholder config. |
| pkg/loop/config.go | Adds env config for enabling the bridge and configuring prefix filters. |
| pkg/loop/config_test.go | Extends env parsing/serialization tests for new bridge env vars. |
| pkg/beholder/config.go | Adds MetricProducers to Beholder config API. |
| pkg/beholder/client.go | Applies MetricProducers to the metrics periodic reader (producer support). |
| pkg/beholder/config_test.go | Replaces prior example output with a JSON golden-file test. |
| pkg/beholder/testdata/config-example.json | New JSON golden file representing example Beholder config. |
| go.mod | Adds OTel Prometheus bridge dependency and updates Prometheus/JWT deps. |
| go.sum | Dependency checksum updates for the above. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+20
| func (g *PrefixGatherer) Gather() ([]*dto.MetricFamily, error) { | ||
| var ret []*dto.MetricFamily | ||
| all, err := g.Gatherer.Gather() | ||
| if err != nil { | ||
| return nil, err |
pavel-raykov
approved these changes
May 22, 2026
pkcll
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CRE-4426
Supports: