Skip to content

add Prometheus bridge to otel#22572

Draft
jmank88 wants to merge 1 commit into
developfrom
bridge-prom
Draft

add Prometheus bridge to otel#22572
jmank88 wants to merge 1 commit into
developfrom
bridge-prom

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented May 20, 2026

https://smartcontract-it.atlassian.net/browse/CRE-4426

This PR adds a Prometheus bridge to forward metrics through otel. It is disabled by default, but can be enabled in whole or for a subset of prefixes via TOML config:

# The Prometheus bridge automatically forwards metrics through open telemetry.
[Telemetry.PrometheusBridge]
# **ADVANCED**
# Enabled enables the Promtheus bridge.
Enabled = false # Default
# Prefixes is a set of filters to restrict which prometheus metrics are forwarded based on prefix matching.
# By default, we only forward the go runtime metrics. Empty means forward everything.
Prefixes = ["go_"] # Default

Requires:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 20, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@jmank88 jmank88 force-pushed the bridge-prom branch 3 times, most recently from acc18b0 to bd04238 Compare May 20, 2026 22:54
@github-actions
Copy link
Copy Markdown
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Enabled = false # Default
# Prefixes is a set of filters to restrict which prometheus metrics are forwarded based on prefix matching.
# By default, we only forward the go runtime metrics. Empty means forward everything.
Prefixes = ["go_"] # Default
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also configure a list of labels/attributes to augment, but IIRC we will already be picking many up from beholder that will allow us to differentiate them when necessary.

pavel-raykov
pavel-raykov previously approved these changes May 21, 2026
pkcll
pkcll previously approved these changes May 21, 2026
@jmank88 jmank88 dismissed stale reviews from pkcll and pavel-raykov via 2ff775d May 22, 2026 20:27
@cl-sonarqube-production
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants