Handle HTTP/1 remote disconnects - #240
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
samuel/handle-client-disconnects
branch
from
August 19, 2026 22:30
6f22433 to
9aae153
Compare
samuel-williams-shopify
force-pushed
the
samuel/handle-client-disconnects
branch
2 times, most recently
from
August 19, 2026 23:53
60eb05e to
42edf09
Compare
samuel-williams-shopify
force-pushed
the
samuel/handle-client-disconnects
branch
from
August 19, 2026 23:59
42edf09 to
f8b8023
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protocol::HTTP::RemoteErrorin the HTTP/1 server loop as a normal remote disconnect.EPIPEfailures.Depends on socketry/protocol-http1#58, which maps connection-level
EPIPEandECONNRESETfailures toProtocol::HTTP::RemoteErrorand prevents connection reuse.Testing
bundle exec bake testbundle exec rubocopbundle exec bake decode:index:coverage lib