Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion async-http.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "io-endpoint", "~> 0.18"
spec.add_dependency "io-stream", "~> 0.14"
spec.add_dependency "protocol-http", "~> 0.66"
spec.add_dependency "protocol-http1", "~> 0.39"
spec.add_dependency "protocol-http1", "~> 0.41"
spec.add_dependency "protocol-http2", "~> 0.26"
spec.add_dependency "protocol-url", "~> 0.2"
end
3 changes: 3 additions & 0 deletions lib/async/http/protocol/http1/server.rb
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ def each(task: Task.current)
# Do not remove this line or you will unleash the gods of concurrency hell.
task.yield
end
rescue ::Protocol::HTTP::RemoteError => error
Console.debug(self, "Remote endpoint disconnected!", exception: error)
return
rescue => error
# We store error (as a local variable) for later use in the ensure block.
raise
Expand Down
4 changes: 4 additions & 0 deletions releases.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Releases

## Unreleased

- Handle remote disconnects in `Async::HTTP::Protocol::HTTP1::Server#each` without reporting them as server failures.

## v0.100.0

- Added transport-neutral TLS configuration support to `Async::HTTP::Endpoint`.
Expand Down
99 changes: 99 additions & 0 deletions test/async/http/protocol/http1/server.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
# frozen_string_literal: true

# Released under the MIT License.
# Copyright, 2026, by Samuel Williams.

require "async/http/protocol/http1/server"

require "async/promise"
require "protocol/http/body/buffered"
require "protocol/http/body/wrapper"
require "sus/fixtures/async/reactor_context"

describe Async::HTTP::Protocol::HTTP1::Server do
include Sus::Fixtures::Async::ReactorContext

let(:server_class) do
Class.new(subject) do
attr :next_request_count

def initialize(error = nil)
super(nil, "HTTP/1.1")

@error = error
@next_request_count = 0
@request = Async::HTTP::Protocol::HTTP1::Request.new(
self,
nil,
"localhost",
"GET",
"/",
"HTTP/1.1",
Protocol::HTTP::Headers.new,
nil,
)
end

def next_request
@next_request_count += 1

request = @request
@request = nil
return request
end

def write_response(...)
end

def write_body(...)
if @error
raise Protocol::HTTP::RemoteError, @error.message, cause: @error
end
end

def hijacked?
false
end
end
end

let(:body_closed) {Async::Promise.new}

let(:body) do
body_closed = self.body_closed

Class.new(Protocol::HTTP::Body::Wrapper) do
define_method(:close) do |error = nil|
body_closed.resolve(error)
super(error)
end
end.new(Protocol::HTTP::Body::Buffered.wrap("Hello World"))
end

[Errno::EPIPE, Errno::ECONNRESET].each do |error_class|
it "handles #{error_class} reported as a remote error", unique: error_class.name do
error = error_class.new
server = server_class.new(error)

server.each do
Protocol::HTTP::Response[200, {}, body]
end

expect(server.next_request_count).to be == 1

expect(body_closed.wait).to be_a(Protocol::HTTP::RemoteError).and(
have_attributes(cause: be_equal(error))
)
end
end

it "propagates errors raised while generating the response" do
server = server_class.new

expect do
server.each do
raise Errno::EPIPE
end
end.to raise_exception(Errno::EPIPE)
end
end
Loading