starknet_os_flow_tests: initial commit of os_resources module#14091
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryMedium Risk Overview The module extracts per-syscall Reviewed by Cursor Bugbot for commit 74a148a. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74a148a. Configure here.
|
|
||
| // Syscalls that make an inner call whose resources must be subtracted from the trace total. | ||
| pub(crate) const CALL_CONTRACT_SYSCALLS: &[DeprecatedSyscallSelector] = | ||
| &[DeprecatedSyscallSelector::CallContract, DeprecatedSyscallSelector::LibraryCall]; |
There was a problem hiding this comment.
MetaTxV0 missing from CALL_CONTRACT_SYSCALLS loses inner-call subtraction
Medium Severity
MetaTxV0 is classified as a calling syscall (per is_calling_syscall()) and the test contract confirms it calls execute_inner_call, which pushes an entry into execute_call_info.inner_calls. However, CALL_CONTRACT_SYSCALLS only lists CallContract and LibraryCall, so MetaTxV0's inner-call VM resources are never subtracted from its raw trace resources. This inflates the extracted constant cost for MetaTxV0 by the cost of the inner call. The comparison margin may mask this today (since the inner call targets an empty function), but the measured value is nonetheless incorrect.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 74a148a. Configure here.



No description provided.