refactor(painter): remove body blocks/measures from DomPainterInput#2820
refactor(painter): remove body blocks/measures from DomPainterInput#2820tupizz wants to merge 1 commit intotadeu/sd-2563-06b-remove-body-fallbacksfrom
Conversation
Body block and measure data now flows exclusively through the resolved layout. The painter only builds a blockLookup from header/footer data, which is the last remaining fallback surface for fragments that do not yet have a resolved path. Complex-transaction rebuild detection now walks the resolved layout items directly instead of iterating the body blockLookup. The legacy createDomPainter wrapper derives a resolved layout from its legacyState blocks/measures on the fly so the benchmark path and direct createDomPainter(options).paint(Layout) callers keep working without setResolvedLayout.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d49d00f326
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "devDependencies": { | ||
| "@superdoc/layout-engine": "workspace:*", | ||
| "@superdoc/layout-resolved": "workspace:*", |
There was a problem hiding this comment.
@superdoc/painter-dom now imports resolveLayout in src/index.ts during normal execution, but @superdoc/layout-resolved is declared only as a devDependency. In production-style installs (pnpm install --prod) devDependencies are pruned, so consumers that depend on @superdoc/painter-dom without also depending on @superdoc/layout-resolved can fail at module resolution time before paint runs. Please declare this package under dependencies to keep runtime resolution stable.
Useful? React with 👍 / 👎.
1 participant
PR Stack (SD-2563: Dumb Painter Refactor)