refactor(painter): deliver resolved items to decoration provider callback#2827
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af974ca4d9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| return { | ||
| fragments: normalizedFragments, | ||
| items: alignedItems, |
There was a problem hiding this comment.
Normalize resolved item coordinates with shifted fragments
When layoutMinY < 0, this branch shifts fragment coordinates (y: f.y - layoutMinY) but returns items unchanged. After this refactor, renderer.renderFragment prefers resolvedItem.y (via applyResolvedFragmentFrame), so non-anchored header/footer fragments are positioned using stale pre-normalization Y values while the rest of the decoration math uses normalized fragment coordinates. In documents where header/footer content extends above y=0, this causes visible vertical misplacement/clipping; the same mismatch is also present in the variant fallback branch.
Useful? React with 👍 / 👎.
PR Stack (SD-2563: Dumb Painter Refactor)