Decouple WorkerCommandLineFactory from symfony/console#9
Merged
Conversation
WorkerCommandLineFactory no longer reflects over a Symfony Console Command to build the worker command line. It now takes plain data (worker command name, scalar option values, paths) and assembles a deterministic command line with the worker command name as the first token. This drops the symfony/console requirement entirely, letting consumers run on any console layer. - rewrite WorkerCommandLineFactory::create() to a plain-data signature - delete CommandFromReflectionFactory (only used by the factory) - remove symfony/console from require - update tests, drop Symfony command fixtures
Member
Author
|
This will require major version bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WorkerCommandLineFactoryreflected over aSymfony\Component\Console\Commandto mirror its options onto the worker sub-process command line. That hard-wiredsymfony/consoleinto the package, blocking consumers that run on a different console layer.What
WorkerCommandLineFactory::create()to a plain-data signature: worker command name, scalar option values, paths, identifier, port. The worker command name is emitted as the first token, so the command line is deterministic and does not depend on a Symfony Command instance.CommandFromReflectionFactory(only used by the factory).symfony/consolefromrequire.WorkerCommandLineFactoryTest, drop the Symfony command fixtures (MainCommand,SomeService).Breaking change
create()signature changed (no longer accepts aCommandobject). Major version bump.Verified
phpunit— 2 tests greenphpstan— no errors