fix(rsc): resolve local function exports - #1380
Draft
hi-ogawa wants to merge 1 commit into
Draft
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformModuleExportWrapand deprecatetransformWrapExport#1370"use cache"Server Functions #1336Realized a slight gap with Next.js
use cachetransform wrapping strategy in #1370. This PR adds a few more logic to align for this specific scenario of accessing local export within the same module.Interesting, at the same time, it also reveals that, if we ignore such local export access semantics, we can actually simplify #1370 without hoist technique, which may be what I land first and leave this PR's complete-but-more-complex variant for future iteration.