feat(rsc): add transformModuleExportWrap and deprecate transformWrapExport (take 2) - #1381
Closed
hi-ogawa wants to merge 93 commits into
Closed
feat(rsc): add transformModuleExportWrap and deprecate transformWrapExport (take 2)#1381hi-ogawa wants to merge 93 commits into
transformModuleExportWrap and deprecate transformWrapExport (take 2)#1381hi-ogawa wants to merge 93 commits into
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai> # Conflicts: # packages/plugin-rsc/src/transforms/server-action.ts # packages/plugin-rsc/src/transforms/source-map.test.ts # packages/plugin-rsc/src/transforms/test-utils.ts
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
…dule-export-wrapper
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
…dule-export-wrapper
Co-authored-by: OpenCode <noreply@opencode.ai>
…t-wrapper Co-authored-by: OpenCode <noreply@opencode.ai>
…t-wrapper Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
marked this pull request as ready for review
August 4, 2026 03:43
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
marked this pull request as draft
August 4, 2026 04:10
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai> # Conflicts: # packages/plugin-rsc/src/transforms/utils.test.ts
Co-authored-by: OpenCode <noreply@opencode.ai>
transformModuleExportWrap and deprecate transformWrapExport (take 2)transformModuleExportWrap and deprecate transformWrapExport (take 2)
Co-authored-by: OpenCode <noreply@opencode.ai>
This was referenced Aug 4, 2026
Contributor
Author
|
closing in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformModuleExportWrapand deprecatetransformWrapExport#1370This is an alternative direction of #1380.
transformModuleExportWraphas slightly simpler model thantransformWrapExportwhere it doesn't try to reassign wrapped export. For example,This can technically differ how local export is perceived in above case, but this wasn't always the case, for example:
So,
transformModuleExportWrapin general aligns the transform strategy to a simplified model. If this specific behavior is aimed to align with Next.jsuse cache, then we should aim for larger strategy rework as prototyped in #1380.