feat(rsc): allow transformWrapExport filter by node ast - #1385
Merged
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
changed the title
transformWrapExport filter
hi-ogawa
changed the title
transformWrapExport filtertransformWrapExport filter
hi-ogawa
marked this pull request as ready for review
August 4, 2026 06:37
hi-ogawa
changed the title
transformWrapExport filtertransformWrapExport filter by node ast
hi-ogawa
commented
Aug 4, 2026
| } from './module-export-scan' | ||
| import { validateNonAsyncFunction } from './utils' | ||
|
|
||
| type ExportMeta = { |
Contributor
Author
There was a problem hiding this comment.
This is also now consolidated with ModuleExportMeta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformModuleExportWrapand deprecatetransformWrapExport(take 2) #1381This PR adds
ModuleExportMeta.valueNode, sotransformWrapExportfilter can decide which node to wrap based on node ast.This allows handling the exotic case of Next.js
use cachewhere it allows array/object export to not be rejected. Seeuse-cache-callableexample for reference.The additional source-map fixtures characterize the current
transformWrapExportandtransformModuleExportEffectbehavior across classes, comments, aliases, recursive references, and local binding preservation.