Skip to content

Add TakeExecute implementation for FilterArray #7393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
robert3005 wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Add TakeExecute implementation for FilterArray #7393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
926f90a
TakeExecute for FilterArray
robert3005 Apr 9, 2026
ada7ed4
fixes
robert3005 May 14, 2026
9f224fc
less
robert3005 May 14, 2026
2b94a17
less
robert3005 May 14, 2026
ef9decd
try
robert3005 May 14, 2026
6d1c9a8
api
robert3005 May 14, 2026
0af4aad
simplify
robert3005 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions vortex-array/public-api.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2764,6 +2764,10 @@ impl vortex_array::arrays::dict::TakeExecute for vortex_array::arrays::Extension

pub fn vortex_array::arrays::Extension::take(vortex_array::ArrayView<'_, vortex_array::arrays::Extension>, &vortex_array::ArrayRef, &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::ArrayRef>>

impl vortex_array::arrays::dict::TakeExecute for vortex_array::arrays::Filter

pub fn vortex_array::arrays::Filter::take(vortex_array::ArrayView<'_, vortex_array::arrays::Filter>, &vortex_array::ArrayRef, &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::ArrayRef>>

impl vortex_array::arrays::dict::TakeExecute for vortex_array::arrays::FixedSizeList

pub fn vortex_array::arrays::FixedSizeList::take(vortex_array::ArrayView<'_, vortex_array::arrays::FixedSizeList>, &vortex_array::ArrayRef, &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::ArrayRef>>
Expand Down Expand Up @@ -2980,6 +2984,10 @@ impl vortex_array::ValidityVTable<vortex_array::arrays::Filter> for vortex_array

pub fn vortex_array::arrays::Filter::validity(vortex_array::ArrayView<'_, vortex_array::arrays::Filter>) -> vortex_error::VortexResult<vortex_array::validity::Validity>

impl vortex_array::arrays::dict::TakeExecute for vortex_array::arrays::Filter

pub fn vortex_array::arrays::Filter::take(vortex_array::ArrayView<'_, vortex_array::arrays::Filter>, &vortex_array::ArrayRef, &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::ArrayRef>>

pub struct vortex_array::arrays::filter::FilterData

impl vortex_array::arrays::filter::FilterData
Expand Down Expand Up @@ -6248,6 +6256,10 @@ impl vortex_array::ValidityVTable<vortex_array::arrays::Filter> for vortex_array

pub fn vortex_array::arrays::Filter::validity(vortex_array::ArrayView<'_, vortex_array::arrays::Filter>) -> vortex_error::VortexResult<vortex_array::validity::Validity>

impl vortex_array::arrays::dict::TakeExecute for vortex_array::arrays::Filter

pub fn vortex_array::arrays::Filter::take(vortex_array::ArrayView<'_, vortex_array::arrays::Filter>, &vortex_array::ArrayRef, &mut vortex_array::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::ArrayRef>>

pub struct vortex_array::arrays::FixedSizeList

impl core::clone::Clone for vortex_array::arrays::FixedSizeList
Expand Down
1 change: 1 addition & 0 deletions vortex-array/src/arrays/filter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ pub use kernel::FilterReduce;
pub use kernel::FilterReduceAdaptor;

mod rules;
mod take;

mod vtable;
pub use vtable::Filter;
Loading
Loading