Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-07-22 - [Missing memoization on regex compilation]
**Learning:** Functions that generate compiled regex patterns on the fly (e.g., `_compiled_context_lexicon` in `openmed.clinical.context`) create severe performance bottlenecks when used repeatedly (e.g., during per-span text evaluations). Without `functools.lru_cache`, the regex compiler is continuously invoked, leading to a massive CPU overhead.
**Action:** When working on text processing pipelines in openmed, always ensure deterministic regex compilation and lexicon generation steps are memoized (e.g., using `@functools.lru_cache`) to prevent unnecessary computation on repeated text segment evaluations.
2 changes: 2 additions & 0 deletions openmed/openmed/clinical/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
from __future__ import annotations

import re
import functools
from collections.abc import Iterable, Iterator, Mapping, Sequence
from dataclasses import dataclass, replace
from datetime import date
Expand Down Expand Up @@ -154,6 +155,7 @@ class _CompiledContextLexicon:
backward_context_cues: frozenset[str]


@functools.lru_cache(maxsize=16)
def _compiled_context_lexicon(language: str | None = None) -> _CompiledContextLexicon:
lexicon = get_clinical_cue_lexicon(language)
token_boundaries = lexicon.token_boundaries
Expand Down