Enroll assisted-service in pipeline controller LGTM mode#81932
Open
jmguzik wants to merge 1 commit into
Open
Conversation
For tests that were already always_run: false without conditionals, add pipeline_run_if_changed: ^$ to prevent them from being auto-triggered in the second stage as "protected" jobs. Signed-off-by: Jakub Guzik <jguzik@redhat.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (30)
📒 Files selected for processing (31)
WalkthroughThe PR updates assisted-service CI configurations across master and release branches to use pipeline-scoped change filters and adds pipeline run conditions for E2E jobs. It also adds assisted-service to both LGTM repository allowlists. ChangesAssisted-service CI condition migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
[REHEARSALNOTIFIER]
A total of 69 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
|
@jmguzik: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tests that were already always_run: false without conditionals, add pipeline_run_if_changed: ^$ to prevent them from being auto-triggered in the second stage as "protected" jobs.
Summary by CodeRabbit
Enrolls assisted-service in pipeline-controller LGTM mode across OpenShift and OpenShift Priv configurations. Updates E2E test change filters and adds
pipeline_run_if_changed: ^$to prevent selected tests from being automatically triggered as protected second-stage jobs.