i18n(ja): move particles trapped inside bold UI-label spans outside - #23559
i18n(ja): move particles trapped inside bold UI-label spans outside#23559yahonda wants to merge 7 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe pull request updates Japanese documentation across AI integrations, development guides, dashboards, TiDB Cloud procedures, troubleshooting pages, and release notes. The changes correct wording, punctuation, links, quotations, icons, and Markdown emphasis. No code or product behavior changes. ChangesDocumentation corrections
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟡 Moderate · up to This corpus-wide formatting change still leaves several Japanese wording, UI-label rendering, and cluster-sizing guidance defects that can mislead users or display labels inconsistently. Merge should wait for these bounded documentation corrections. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 26
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a59a65f9-2df6-4409-b52a-5bd0ec7cbcc2
📒 Files selected for processing (114)
ai/integrations/tidb-mcp-cursor.mdai/integrations/vector-search-integrate-with-amazon-bedrock.mdai/integrations/vector-search-integrate-with-django-orm.mdai/integrations/vector-search-integrate-with-jinaai-embedding.mdai/integrations/vector-search-integrate-with-langchain.mdai/integrations/vector-search-integrate-with-llamaindex.mdai/integrations/vector-search-integrate-with-peewee.mdai/integrations/vector-search-integrate-with-sqlalchemy.mdai/vector-search-get-started-using-python.mdbenchmark/v4.0-performance-benchmarking-with-tpch.mddashboard/continuous-profiling.mddashboard/dashboard-cluster-info.mddashboard/dashboard-diagnostics-access.mddashboard/dashboard-resource-manager.mddashboard/dashboard-session-share.mddashboard/dashboard-session-sso.mddeploy-monitoring-services.mddevelop/dev-guide-aws-appflow-integration.mddevelop/dev-guide-connection-parameters.mddevelop/dev-guide-create-table.mddevelop/dev-guide-gui-datagrip.mddevelop/dev-guide-gui-dbeaver.mddevelop/dev-guide-gui-mysql-workbench.mddevelop/dev-guide-gui-navicat.mddevelop/dev-guide-gui-vscode-sqltools.mddevelop/dev-guide-proxysql-integration.mddevelop/dev-guide-sample-application-aws-lambda.mddevelop/dev-guide-sample-application-golang-gorm.mddevelop/dev-guide-sample-application-golang-sql-driver.mddevelop/dev-guide-sample-application-java-hibernate.mddevelop/dev-guide-sample-application-java-jdbc.mddevelop/dev-guide-sample-application-java-mybatis.mddevelop/dev-guide-sample-application-java-spring-boot.mddevelop/dev-guide-sample-application-nextjs.mddevelop/dev-guide-sample-application-nodejs-mysql2.mddevelop/dev-guide-sample-application-nodejs-mysqljs.mddevelop/dev-guide-sample-application-nodejs-prisma.mddevelop/dev-guide-sample-application-nodejs-sequelize.mddevelop/dev-guide-sample-application-nodejs-typeorm.mddevelop/dev-guide-sample-application-python-django.mddevelop/dev-guide-sample-application-python-mysql-connector.mddevelop/dev-guide-sample-application-python-mysqlclient.mddevelop/dev-guide-sample-application-python-peewee.mddevelop/dev-guide-sample-application-python-pymysql.mddevelop/dev-guide-sample-application-python-sqlalchemy.mddevelop/dev-guide-sample-application-ruby-mysql2.mddevelop/dev-guide-schema-design-overview.mddevelop/dev-guide-timeouts-in-tidb.mddevelop/dev-guide-transaction-restraints.mddevelop/dev-guide-update-data.mddevelop/dev-guide-wordpress.mdexternal-storage-uri.mdgrafana-tikv-dashboard.mdresources/tidb-pdf-generation-tutorial.mdticdc/integrate-confluent-using-ticdc.mdticdc/ticdc-bidirectional-replication.mdtidb-cloud/backup-and-restore.mdtidb-cloud/branch-manage.mdtidb-cloud/changefeed-sink-to-apache-kafka.mdtidb-cloud/configure-external-storage-access.mdtidb-cloud/configure-maintenance-window.mdtidb-cloud/configure-serverless-firewall-rules-for-public-endpoints.mdtidb-cloud/configure-sql-users.mdtidb-cloud/connected-care-overview.mdtidb-cloud/create-tidb-cluster-serverless.mdtidb-cloud/data-service-api-key.mdtidb-cloud/data-service-custom-domain.mdtidb-cloud/data-service-manage-data-app.mdtidb-cloud/data-service-manage-endpoint.mdtidb-cloud/data-service-manage-github-connection.mdtidb-cloud/data-service-oas-with-nextjs.mdtidb-cloud/data-service-postman-integration.mdtidb-cloud/essential-changefeed-sink-to-kafka.mdtidb-cloud/essential-database-audit-logging.mdtidb-cloud/import-csv-files.mdtidb-cloud/import-parquet-files-serverless.mdtidb-cloud/import-parquet-files.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/migrate-incremental-data-from-mysql-using-data-migration.mdtidb-cloud/migrate-sql-shards.mdtidb-cloud/monitor-alert-email.mdtidb-cloud/monitor-alert-flashduty.mdtidb-cloud/monitor-alert-pagerduty.mdtidb-cloud/monitor-alert-slack.mdtidb-cloud/monitor-alert-zoom.mdtidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/pause-or-resume-tidb-cluster.mdtidb-cloud/premium/connect-to-premium-via-aws-private-endpoint.mdtidb-cloud/premium/create-tidb-instance-premium.mdtidb-cloud/premium/dual-layer-data-encryption-premium.mdtidb-cloud/premium/import-from-s3-premium.mdtidb-cloud/releases/release-notes-2023.mdtidb-cloud/releases/release-notes-2025.mdtidb-cloud/scale-tidb-cluster.mdtidb-cloud/serverless-export.mdtidb-cloud/serverless-private-link-connection-to-amazon-msk.mdtidb-cloud/serverless-private-link-connection-to-aws-rds.mdtidb-cloud/set-up-private-endpoint-connections-on-azure.mdtidb-cloud/set-up-private-endpoint-connections-on-google-cloud.mdtidb-cloud/set-up-sink-private-endpoint.mdtidb-cloud/setup-azure-self-hosted-kafka-private-link-service.mdtidb-cloud/setup-self-hosted-kafka-private-service-connect.mdtidb-cloud/size-your-cluster.mdtidb-cloud/tidb-cloud-auditing.mdtidb-cloud/tidb-cloud-budget.mdtidb-cloud/tidb-cloud-password-authentication.mdtidb-cloud/tidb-cloud-poc.mdtidb-cloud/tidb-cloud-quickstart.mdtidb-cloud/tidb-cloud-support.mdtidb-cloud/top-ru.mdtidb-cloud/v8.5-performance-highlights.mdtidb-troubleshooting-map.mdtroubleshoot-write-conflicts.mdtune-tikv-thread-performance.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
…odeRabbit Addresses CodeRabbit's functional-correctness findings on PR pingcap#23559: - dev-guide-gui-dbeaver.md: closing quote outside the bold dialog label (4x) - naming-conventions-for-data-import.md, pause-or-resume-tidb-cluster.md, data-service-custom-domain.md: opening quote outside the bold status/field label - branch-manage.md: closing bold marker inside the bracketed [Action] label - connected-care-overview.md: duplicated word (異なる異なる) - data-service-manage-github-connection.md: missing し in デプロイして - migrate-from-mysql-using-data-migration.md: bold span cut a word in half with no genuine UI label to emphasize; unbolded the plain prose - essential-changefeed-sink-to-kafka.md, changefeed-sink-to-apache-kafka.md: align the Avro conditional phrasing within each procedure
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tidb-cloud/size-your-cluster.md (1)
272-272: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winRequest the TiKV storage type in the Plus storage procedure.
This section documents TiKV storage, but the request text says
TiFlashストレージタイプを申請. Support may process the wrong storage request.Apply this exact replacement
-Plusストレージは、より高いパフォーマンスと安定性を提供し、これらの拡張機能を反映した価格設定となっています。現在、このストレージタイプは、AWSにデプロイされたクラスターに対してのみ、リクエストに応じて利用可能です。リクエストするには、 [TiDB Cloudコンソール](https://tidbcloud.com)の右下にある**「?」**をクリックし、 **Support Tickets**をクリックして[ヘルプセンター](https://tidb.support.pingcap.com/servicedesk/customer/portals)に進みます。チケットを作成し、 **「説明」**フィールドに「 TiFlashストレージタイプを申請」と入力して、 **「送信」**をクリックしてください。 +Plusストレージは、より高いパフォーマンスと安定性を提供し、これらの拡張機能を反映した価格設定となっています。現在、このストレージタイプは、AWSにデプロイされたクラスターに対してのみ、リクエストに応じて利用可能です。リクエストするには、 [TiDB Cloudコンソール](https://tidbcloud.com)の右下にある**「?」**をクリックし、 **Support Tickets**をクリックして[ヘルプセンター](https://tidb.support.pingcap.com/servicedesk/customer/portals)に進みます。チケットを作成し、 **「説明」**フィールドに「TiKVストレージタイプを申請」と入力して、 **「送信」**をクリックしてください。As per path instructions, this Markdown fix is provided as an exact replacement.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c6096136-e5fa-4dad-93ba-de23c1ed6cde
📒 Files selected for processing (46)
dashboard/continuous-profiling.mddeploy-monitoring-services.mddevelop/dev-guide-aws-appflow-integration.mddevelop/dev-guide-connection-parameters.mddevelop/dev-guide-sample-application-java-hibernate.mddevelop/dev-guide-sample-application-java-jdbc.mddevelop/dev-guide-sample-application-java-mybatis.mddevelop/dev-guide-sample-application-java-spring-boot.mddevelop/dev-guide-sample-application-nodejs-mysql2.mddevelop/dev-guide-sample-application-nodejs-mysqljs.mddevelop/dev-guide-sample-application-nodejs-prisma.mddevelop/dev-guide-sample-application-nodejs-sequelize.mddevelop/dev-guide-sample-application-nodejs-typeorm.mddevelop/dev-guide-sample-application-python-django.mddevelop/dev-guide-sample-application-python-mysql-connector.mddevelop/dev-guide-sample-application-python-mysqlclient.mddevelop/dev-guide-sample-application-python-peewee.mddevelop/dev-guide-sample-application-python-pymysql.mddevelop/dev-guide-sample-application-python-sqlalchemy.mddevelop/dev-guide-sample-application-ruby-mysql2.mddevelop/dev-guide-schema-design-overview.mddevelop/dev-guide-timeouts-in-tidb.mddevelop/dev-guide-update-data.mdexternal-storage-uri.mdresources/tidb-pdf-generation-tutorial.mdtidb-cloud/backup-and-restore.mdtidb-cloud/changefeed-sink-to-apache-kafka.mdtidb-cloud/configure-sql-users.mdtidb-cloud/connected-care-overview.mdtidb-cloud/data-service-manage-github-connection.mdtidb-cloud/data-service-oas-with-nextjs.mdtidb-cloud/essential-changefeed-sink-to-kafka.mdtidb-cloud/essential-database-audit-logging.mdtidb-cloud/migrate-incremental-data-from-mysql-using-data-migration.mdtidb-cloud/monitor-datadog-integration.mdtidb-cloud/premium/dual-layer-data-encryption-premium.mdtidb-cloud/releases/release-notes-2023.mdtidb-cloud/serverless-private-link-connection-to-amazon-msk.mdtidb-cloud/serverless-private-link-connection-to-aws-rds.mdtidb-cloud/set-up-private-endpoint-connections-on-azure.mdtidb-cloud/set-up-private-endpoint-connections-on-google-cloud.mdtidb-cloud/setup-azure-self-hosted-kafka-private-link-service.mdtidb-cloud/size-your-cluster.mdtidb-cloud/tidb-cloud-password-authentication.mdtidb-cloud/top-ru.mdtidb-troubleshooting-map.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
Across 120 files, a Japanese particle (を/の/が/に/は/で/と) was bolded together with the preceding label instead of sitting outside the bold span, e.g. **Raft store CPU を** instead of **Raft store CPU**を. Move the trailing particle outside the closing ** to match the convention used throughout the rest of the corpus. Also fixes two related straddling-bracket typos found in the same sweep (external-storage-uri.md, set-up-private-endpoint-connections-on-google-cloud.md).
…found in 1:1 EN review Full 1:1 comparison against the English source for every file touched by the particle-trapped-in-bold sweep, covering: - dropped particles (を/が/は/の/で) near links, buttons, and identifiers - garbled/duplicated text fragments and misplaced links - a systemic straddling-bracket + garbled IP-access-list sentence repeated across 15 dev-guide-sample-application-*.md files - broken <mdsvgicon> container tags restored to self-closing <MDSvgIcon /> - one inverted-meaning mistranslation (Batch Operation / DELETE) in tidb-cloud/releases/release-notes-2023.md - a garbled repo-name link (tikv/tikv, tikv/pd) in deploy-monitoring-services.md
…odeRabbit Addresses CodeRabbit's functional-correctness findings on PR pingcap#23559: - dev-guide-gui-dbeaver.md: closing quote outside the bold dialog label (4x) - naming-conventions-for-data-import.md, pause-or-resume-tidb-cluster.md, data-service-custom-domain.md: opening quote outside the bold status/field label - branch-manage.md: closing bold marker inside the bracketed [Action] label - connected-care-overview.md: duplicated word (異なる異なる) - data-service-manage-github-connection.md: missing し in デプロイして - migrate-from-mysql-using-data-migration.md: bold span cut a word in half with no genuine UI label to emphasize; unbolded the plain prose - essential-changefeed-sink-to-kafka.md, changefeed-sink-to-apache-kafka.md: align the Avro conditional phrasing within each procedure
cf009e3 to
4f6093a
Compare
FetchSize から Integer.MIN_VALUE に設定する should use を...に instead of から (set FetchSize TO Integer.MIN_VALUE, not FROM).
a55da1c to
ea22bca
Compare
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
develop/dev-guide-aws-appflow-integration.md (1)
138-138: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winKeep Japanese quotation marks inside the bold UI labels.
develop/dev-guide-aws-appflow-integration.md#L138-L138: change「**接続」**to**「接続」**.develop/dev-guide-gui-dbeaver.md#L71-L71: change**「接続方法**」to**「接続方法」**.Source: Path instructions
tidb-cloud/monitor-alert-flashduty.md (1)
61-61: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winKeep particles outside bold UI labels.
tidb-cloud/monitor-alert-flashduty.md#L61-L61: change**加入者タイプの**to**加入者タイプ**の.tidb-cloud/monitor-alert-flashduty.md#L90-L90: change**加入者タイプの**to**加入者タイプ**の.tidb-cloud/monitor-alert-flashduty.md#L117-L117: change**加入者タイプの**to**加入者タイプ**の.tidb-cloud/monitor-alert-slack.md#L62-L62: change**購読者タイプの**to**購読者タイプ**の.tidb-cloud/monitor-alert-slack.md#L91-L91: change**購読者タイプの**to**購読者タイプ**の.tidb-cloud/monitor-alert-slack.md#L118-L118: change**購読者タイプの**to**購読者タイプ**の.Source: Path instructions
develop/dev-guide-gui-mysql-workbench.md (1)
78-78: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winCorrect the shared Japanese UI-label emphasis boundaries. The changed lines close
**afterという, before」, or afterの, so the rendered labels include the wrong text.
develop/dev-guide-gui-mysql-workbench.md#L78-L78: close the bold span after」and beforeという.develop/dev-guide-gui-mysql-workbench.md#L149-L149: close the bold span after」and beforeという.develop/dev-guide-gui-mysql-workbench.md#L174-L174: close the bold span after」and beforeという.develop/dev-guide-gui-navicat.md#L74-L74: close the bold span after」and beforeという.develop/dev-guide-gui-navicat.md#L112-L112: close the bold span after」and beforeという.develop/dev-guide-gui-navicat.md#L143-L143: close both label spans after」; keepのoutside the second span.develop/dev-guide-gui-navicat.md#L149-L149: close the bold span after」and beforeという.develop/dev-guide-gui-navicat.md#L170-L170: close the bold span after」and beforeという.Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1aadb28d-27fe-459c-af5f-af0180ca40b5
📒 Files selected for processing (29)
develop/dev-guide-aws-appflow-integration.mddevelop/dev-guide-connection-parameters.mddevelop/dev-guide-gui-datagrip.mddevelop/dev-guide-gui-dbeaver.mddevelop/dev-guide-gui-mysql-workbench.mddevelop/dev-guide-gui-navicat.mdresources/tidb-pdf-generation-tutorial.mdticdc/integrate-confluent-using-ticdc.mdtidb-cloud/backup-and-restore.mdtidb-cloud/branch-manage.mdtidb-cloud/changefeed-sink-to-apache-kafka.mdtidb-cloud/configure-external-storage-access.mdtidb-cloud/connected-care-overview.mdtidb-cloud/data-service-custom-domain.mdtidb-cloud/data-service-manage-github-connection.mdtidb-cloud/data-service-postman-integration.mdtidb-cloud/essential-changefeed-sink-to-kafka.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/migrate-sql-shards.mdtidb-cloud/monitor-alert-flashduty.mdtidb-cloud/monitor-alert-slack.mdtidb-cloud/monitor-alert-zoom.mdtidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/pause-or-resume-tidb-cluster.mdtidb-cloud/premium/create-tidb-instance-premium.mdtidb-cloud/releases/release-notes-2023.mdtidb-cloud/tidb-cloud-auditing.mdtidb-cloud/tidb-cloud-poc.mdtidb-cloud/tidb-cloud-quickstart.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
- dev-guide-aws-appflow-integration.md: remove duplicated "console" noun after a link that already says "AWS Management Console" - dev-guide-connection-parameters.md: add missing particle before "enable"; fix "actual numeric value HDD" mistranslation of "actual number of HDD" - changefeed-sink-to-apache-kafka.md: add missing particle before "data types" - configure-external-storage-access.md: move Japanese comma/particle outside bold IAM-permission-name spans (x3), matching this PR's particle-trapped-in-bold fix pattern Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The English source never wraps a bold UI-label span (e.g. Click **Connect**) in quotes, but the ja translation had accumulated 「」 around many such spans (e.g. **「接続」**), across single-word button labels, symbols (**「+」**, **「...」**), and longer descriptive labels (**「クラウドストレージからデータをインポート」**). Verified this pattern holds against EN for a representative sample across short and long labels before doing a mechanical, corpus-wide strip: **「X」** -> **X**, applied only where the quote marks sit immediately inside the bold delimiters (1,577 occurrences across 233 files). This supersedes the narrower carve-outs used in PR pingcap#23551/pingcap#23552, which kept a handful of terms quoted for in-file convention (接続 タイプ, スキーマロード, 接続方法, 組織設定, etc.) - per the standing policy, in-file consistency is not a reason to keep quoting a term EN never quotes. Verified per-file: line count, ** count, [ count, and ] count are all unchanged (0 anomalies across all 233 changed files) - only the 「」 characters were removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…-bold-2026-08-19 Resolved 42 file conflicts (took this branch's particle-fix as the base, then re-applied the quote-stripping substitution on top). Also found and fixed a gap: several lines had a particle trapped between the closing 」 and the closing ** (e.g. **「X」を**), which this branch's own fix correctly un-traps to **「X」**を - but since that line wasn't conflicted (fix-strip-non-en-quotes-2026-08-20 couldn't match the trapped-particle form in the base branch), git auto-merged it without reprocessing, leaving the quotes in place. Ran a second, whole-tree pass of the quote-strip substitution after the merge to catch these newly-matchable cases: 92 more occurrences across 62 files. Verified 0 remaining quote-wrapped bold spans and 0 bracket-count anomalies across all 238 changed files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
test seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
[LGTM Timeline notifier]Timeline:
|
First-time contributors' checklist
What is changed, added or deleted? (Required)
Corpus-wide sweep for a defect where a Japanese particle (を/の/が/に/は/で/と) was bolded together with the preceding label instead of sitting outside the bold span, e.g.
**Raft store CPU を**instead of**Raft store CPU**を. This is inconsistent with the convention used throughout the rest of the corpus, where only the label/term is bolded and the particle is plain text.**.external-storage-uri.md,tidb-cloud/set-up-private-endpoint-connections-on-google-cloud.md) where a bracket was split across the bold boundary.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
setQueryTimeout()limitations for older TiDB versions and disabled global-kill configurations.