Channels last: teach the data-movement passes both permute dialects - #22003
Open
rascani wants to merge 3 commits into
Open
Channels last: teach the data-movement passes both permute dialects#22003rascani wants to merge 3 commits into
rascani wants to merge 3 commits into
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22003
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 40 Pending, 1 Unrelated FailureAs of commit f386275 with merge base 2c88f57 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 21, 2026
This PR needs a
|
This was referenced Aug 21, 2026
rascani
marked this pull request as ready for review
August 21, 2026 20:57
AdrianLundell
approved these changes
Aug 24, 2026
MartinPavella
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect the aten and channels_last permute targets into one shared set and
thread it through the transforms that match, fuse, or assert on a permute.
Before this the passes matched aten.permute_copy by identity, so a
channels_last.permute_copy pair inserted by the layout replacement was
invisible to every canceller in the tree and survived untouched.
No pass gains a new capability; each simply stops ignoring half of the
operators it was written to handle. Inert for callers that never produce the
dialect, which today is all of them.
91 pre-existing permute and channels-last tests, plus a case pinning that an
inverse layout-copy pair around an elementwise operator now cancels.
Authored with Codex.