Delete unused new_from_server_update function.#11112
Merged
vorporeal merged 1 commit intoMay 20, 2026
Merged
Conversation
This was referenced May 16, 2026
Contributor
Author
This was referenced May 16, 2026
vorporeal
force-pushed
the
david/delete-unused-new_from_server_update-function
branch
from
41b46d5 to
8d2525a
Compare
This was referenced May 18, 2026
vorporeal
force-pushed
the
david/delete-unused-new_from_server_update-function
branch
from
8d2525a to
f858ad7
Compare
vorporeal
force-pushed
the
david/delete-unused-new_from_server_update-function
branch
from
f858ad7 to
eded2de
Compare
1 task
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
bnavetta
approved these changes
May 20, 2026
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR removes the unused new_from_server_update trait method from CloudModelType/StringModel and deletes the corresponding implementations plus now-unused ServerCloudObject imports.
Concerns
- No blocking concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This function is wholly unused, so this simply removes it.