Create cloud_objects crate.#11165
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5e352da to
f5fc243
Compare
d5b94a3 to
b434157
Compare
f5fc243 to
df91010
Compare
b434157 to
bac2d6a
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR introduces a new cloud_objects crate and moves shared cloud object, Drive sharing, ID, and user UID types out of warp_server_client, while keeping compatibility re-exports for existing call sites.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
bac2d6a to
9239c96
Compare
df91010 to
5cfd599
Compare
9239c96 to
ec7be2a
Compare
3fd9cf9 to
9ba6eed
Compare
ec7be2a to
65ec5ea
Compare
9ba6eed to
ba1e0b4
Compare
65ec5ea to
631c76e
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
631c76e to
d14fff2
Compare
ba1e0b4 to
a9aa277
Compare

Description
Creates a dedicated
cloud_objectscrate for the shared cloud object substrate that should not live inwarp_server_clientor the app crate.The new crate owns the low-level cloud object, Drive sharing, ID, and user UID types.
warp_server_clientnow depends on that crate and re-exports the moved modules so existing call sites can migrate incrementally while keeping this PR mostly mechanical.Linked Issue
None.
Testing
cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_objects -p warp_server_client --testscargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --testsNo manual app testing; this is a crate-boundary refactor with no intended product behavior changes.
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev