Skip to content

Create cloud_objects crate.#11165

Open
vorporeal wants to merge 1 commit into
david/start-moving-cloud-object-modelsfrom
david/create-cloud-objects-crate
Open

Create cloud_objects crate.#11165
vorporeal wants to merge 1 commit into
david/start-moving-cloud-object-modelsfrom
david/create-cloud-objects-crate

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 18, 2026

Description

Creates a dedicated cloud_objects crate for the shared cloud object substrate that should not live in warp_server_client or the app crate.

The new crate owns the low-level cloud object, Drive sharing, ID, and user UID types. warp_server_client now depends on that crate and re-exports the moved modules so existing call sites can migrate incrementally while keeping this PR mostly mechanical.

Linked Issue

None.

Testing

  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_objects -p warp_server_client --tests
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests

No manual app testing; this is a crate-boundary refactor with no intended product behavior changes.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

Copy link
Copy Markdown
Contributor Author

vorporeal commented May 18, 2026

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 20, 2026

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR introduces a new cloud_objects crate and moves shared cloud object, Drive sharing, ID, and user UID types out of warp_server_client, while keeping compatibility re-exports for existing call sites.

Concerns

  • No blocking correctness, security, or spec-alignment concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@vorporeal vorporeal force-pushed the david/start-moving-cloud-object-models branch from bac2d6a to 9239c96 Compare May 20, 2026 15:56
@vorporeal vorporeal force-pushed the david/create-cloud-objects-crate branch from df91010 to 5cfd599 Compare May 20, 2026 15:56
@vorporeal vorporeal force-pushed the david/start-moving-cloud-object-models branch from 9239c96 to ec7be2a Compare May 21, 2026 14:59
@vorporeal vorporeal force-pushed the david/create-cloud-objects-crate branch 2 times, most recently from 3fd9cf9 to 9ba6eed Compare May 21, 2026 16:47
@vorporeal vorporeal force-pushed the david/start-moving-cloud-object-models branch from ec7be2a to 65ec5ea Compare May 21, 2026 16:47
@vorporeal vorporeal force-pushed the david/create-cloud-objects-crate branch from 9ba6eed to ba1e0b4 Compare May 22, 2026 18:51
@vorporeal vorporeal force-pushed the david/start-moving-cloud-object-models branch from 65ec5ea to 631c76e Compare May 22, 2026 18:51
Co-Authored-By: Oz <oz-agent@warp.dev>
@vorporeal vorporeal force-pushed the david/start-moving-cloud-object-models branch from 631c76e to d14fff2 Compare May 22, 2026 18:53
@vorporeal vorporeal force-pushed the david/create-cloud-objects-crate branch from ba1e0b4 to a9aa277 Compare May 22, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant