Replace some custom copy functions with #[derive(Clone)].

[vorporeal]

Description

Addresses #11113 (comment).

[vorporeal]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Replace some custom copy functions with #[derive(Clone)]. #11487 👈 (View in Graphite)
• Extract cloud object persistence logic to other crates. #11179 : 1 other dependent PR (#11378 )
• Extract CloudObject client and models to separate crates. #11166
• Create cloud_objects crate. #11165
• Move cloud object models to separate crate. #11164
• Move GenericStringModel to warp_server_client. #11117
• Move GenericCloudObject to warp_server_client. #11115
• Move GenericServerObject to warp_server_client. #11114
• Move some types to the warp_server_client crate. #11113
• Delete unused new_from_server_update function. #11112
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@vorporeal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR replaces a handwritten Clone implementation for ObjectsToUpdate with #[derive(Clone)] and adds Clone to UpdatedObjectInput, preserving the existing deep-clone behavior through the fields' Clone implementations.

Concerns

• No blocking correctness, security, or spec-alignment concerns found. No approved spec context was provided for this PR.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz